Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <49e5ab55-c7db-5861-4eb4-bc68dc814084@quicinc.com>
Date:   Fri, 6 May 2022 11:53:10 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 1/2] nl80211: process additional attributes in
 NL80211_CMD_SET_BEACON
Content-Language: en-US
To:     Jeff Johnson <quic_jjohnson@quicinc.com>,
        <johannes@sipsolutions.net>
CC:     <linux-wireless@vger.kernel.org>
References: <20220505173449.4424-1-quic_alokad@quicinc.com>
 <20220505173449.4424-2-quic_alokad@quicinc.com>
 <5235cf9e-ad4c-3557-e1ee-d4ece1187652@quicinc.com>
From:   Aloka Dixit <quic_alokad@quicinc.com>
In-Reply-To: <5235cf9e-ad4c-3557-e1ee-d4ece1187652@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/6/2022 11:22 AM, Jeff Johnson wrote:
> On 5/5/2022 10:34 AM, Aloka Dixit wrote:
>> -    struct cfg80211_beacon_data params;
>> +    struct cfg80211_ap_settings params;
>>       int err;
>> +    memset(&params, 0, sizeof(params));
>> +
> 
> is adding an = {} initializer preferable?
> 

I will change this from static to dynamic allocation in the next version 
instead because noticed following error with some compiler:
error: the frame size of 1032 bytes is larger than 1024 bytes 
[-Werror=frame-larger-than=]

>> +    if (info->attrs[NL80211_ATTR_UNSOL_BCAST_PROBE_RESP]) {
>> +        err = nl80211_parse_unsol_bcast_probe_resp(
>> +                rdev, info->attrs[NL80211_ATTR_UNSOL_BCAST_PROBE_RESP],
>> +                &params);
>> +        if (err)
>> +            goto out;
>> +    }
>> +
> 
> would adding a local variable 'attr' make the code more readable?
>      attr = info->attrs[NL80211_ATTR_{foo}];
>      if (attr) {
>          err = nl80211_parse_{foo}(rdev, attr, &params);
> 

Sure, thanks.