Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4940586iob; Mon, 9 May 2022 05:20:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtu5h1HhEmqJ3LjNOTKDYpFuYuYnHqMvj9snEcUuXXX9RM7i1GjsMA9lKINWeOH0Hn0c+O X-Received: by 2002:a17:90b:4f89:b0:1dc:6cca:1d66 with SMTP id qe9-20020a17090b4f8900b001dc6cca1d66mr17993179pjb.129.1652098836579; Mon, 09 May 2022 05:20:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652098836; cv=none; d=google.com; s=arc-20160816; b=hIxrJIaj/GN0tpiF+dxNE+EzLhfiyyD4fH0GeTqausBCM/AYV/umSCUdZ6HmOhDHGT IaVK8bgKC4JlWsOAY4ET0xrkF7LIBoMUB17zT2tEXw5SugQaDj55PIEl4y3ewSmwxhyb /OVgAp/mKGOzxB/Mn1ssoQc2YNwb8xwltyYEvp9e+qD0UA4cWIVjA5DhJnuBRKRZcTK1 UAcLK2IJQrTrXyI5H6YxRlympwtu6QitTUHPqYoXAwcHAPxYQ/p1yJJBSj56XnTLts0O 2oV04Bz3uQCENZPIzl14OkrgmJux2l1vM18j1ys5LBrJwJQ50UmoNw2of5/WWibjGQCA 1j2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=G1lg7nb1APhIek1T8loPaGDIsAcFGBbzw99kf+IcqXE=; b=sTlwLF4awlVamS5/RrTOFxCbjSSjyntktIb2cEQvKW8UcwisSglmmq0uWhR7wjMfkK uIZOYB+QikZIo1CRGXxHhRsp4Olrl7nlgjelLPoxVBMiXLDhLsoh+9EPdotbiI1F7lOB HgmpszBD6XMU3kzW6e5+Otuy76K6bMfJCjU2vJS8QXFHViiktY+wwPkqr0WU3Ofph3Is X/3beRrN56g2trWJjp//BuVcp8OyBoyedEIBTXhs6HJNFJG2qzaf7Sy8iXDUmCVRJumS ieqb2BufoM411RZqQosrNq1fGuhtRetYCebaP1+Meq1rc/p2nPsCXg/qyHS2VQ9CyFeO JhTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O6j9krbT; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id q7-20020a655247000000b003816043f118si5294477pgp.781.2022.05.09.05.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 05:20:36 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O6j9krbT; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1D7999BADD; Mon, 9 May 2022 04:51:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233483AbiEILy4 (ORCPT + 69 others); Mon, 9 May 2022 07:54:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233475AbiEILyy (ORCPT ); Mon, 9 May 2022 07:54:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A91419590F for ; Mon, 9 May 2022 04:50:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11EC6611CA for ; Mon, 9 May 2022 11:50:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87FC0C385AF; Mon, 9 May 2022 11:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652097053; bh=JrJh/aizYV5fErvoTllW4dPM77/hns+tqqCLZufThEM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=O6j9krbT3u+n0JF9SG5a96uQn6o/2ELZ5keCwVu0HcfLT/iD9YkNB7FMT+wjPMIX+ JTTv3F52be93atRFrx5izUJ5RmiRj2T6q3fuZawxil5fMJt+4ei+QfgYc7atAi8qX1 Ap68ChwSD0qf0fONj7tnVSpN1MRXxXWE/mXSz1pj4bqbsskNKEVPazY/PdxqFvJMiM SntuDFN6z34C7oQ+pKHDPr1YRlVYCv4JDuhAUe6ZzW2C44pey6P3Djq9HISgeZldUG Jruqh9yMkkiLdJRetm6HJNdlUXhinnZbBiPSO3FD8v4FnTJ+s5JFkYM/lvNa6MBRRX UIjm/7pdpPggw== From: Kalle Valo To: Cc: , , Subject: Re: [PATCH 3/5] wilc1000: fix crash observed in AP mode with cfg80211_register_netdevice() References: <20220504161924.2146601-1-ajay.kathat@microchip.com> <20220504161924.2146601-3-ajay.kathat@microchip.com> Date: Mon, 09 May 2022 14:50:46 +0300 In-Reply-To: <20220504161924.2146601-3-ajay.kathat@microchip.com> (Ajay Kathat's message of "Wed, 4 May 2022 16:19:26 +0000") Message-ID: <87pmkmylex.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org writes: > From: Ajay Singh > > Monitor(mon.) interface is used for handling the AP mode and 'ieee80211_ptr' > reference is not getting set for it. Like earlier implementation, > use register_netdevice() instead of cfg80211_register_netdevice() which > expects valid 'ieee80211_ptr' reference to avoid the possible crash. > > Fixes: 2fe8ef106238 ("cfg80211: change netdev registration/unregistration semantics") > Signed-off-by: Ajay Singh Is there a reason why wilc1000 does not use ieee8011_ptr? And what earlier implementation are you referring to? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches