Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <57cb3e2f1ba75aec472ca5cfdcd8fc3c7ffffeb0.camel@sipsolutions.net>
Subject: Re: [PATCH 3/5] wilc1000: fix crash observed in AP mode with
 cfg80211_register_netdevice()
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Ajay.Kathat@microchip.com, kvalo@kernel.org
Cc:     linux-wireless@vger.kernel.org, Claudiu.Beznea@microchip.com,
        Sripad.Balwadgi@microchip.com
Date:   Mon, 09 May 2022 21:44:40 +0200
In-Reply-To: <aeafb6e2-d294-475b-1c43-1f90bf8d5114@microchip.com>
References: <20220504161924.2146601-1-ajay.kathat@microchip.com>
         <20220504161924.2146601-3-ajay.kathat@microchip.com>
         <87pmkmylex.fsf@kernel.org>
         <aeafb6e2-d294-475b-1c43-1f90bf8d5114@microchip.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2022-05-09 at 13:49 +0000, Ajay.Kathat@microchip.com wrote:
> 
> As I understand, in WILC "ieee80211_ptr" is used for the station/AP 
> interface but not to configure the monitor interface which gets 
> additionally added in AP mode. In AP mode, for an interface( wlan0 ), an 
> additional monitor interface( mon.wlan0 ) gets created. A netdevice is 
> register for monitor interface(mon.wlan0) to transmit/receive frames 
> from/to hostapd. That interface doesn't explicitly set up 
> 'ieee80211_ptr' because the original interface(wlan0) uses it, so using 
> "cfg80211_register/unregister" API's for mon.wlan0 interfaces fails.

Btw, this probably should just be removed in favour of using the nl80211
based APIs for hostapd ...

But I think as a quick bugfix goes this is fine, but it'd be better to
remove this and either allow hostapd to create the interface with the
proper ieee80211_ptr, or to just use the nl80211-based TX/RX.

johannes