Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220418071313.882179-1-wlooi@ucalgary.ca>
In-Reply-To: <20220418071313.882179-1-wlooi@ucalgary.ca>
From:   Wenli Looi <wlooi@ucalgary.ca>
Date:   Tue, 10 May 2022 11:39:11 -0700
Message-ID: <CAKe_nd1-twgutVV8Ls_7Y=q8o6ua9_W9x6q_HvevWsv3uwnh5Q@mail.gmail.com>
Subject: Re: [PATCH 0/9] ath9k: add support for QCN550x
To:     =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>,
        Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nlk2cy9wckhoZWI5OFc5ZGFsT1V5WWtWSnF0b0ZyYld1MkdsMThhUlVXRUVP?=
 =?utf-8?B?TzJNWDlZQWdKVVVuTHNYRlF5Y0c3eGttTDNpNmpJU1dJVDQzVHl2aERtMmJJ?=
 =?utf-8?B?WW5kMkNsZjNUcFBpOFJxRjZiZ1daaUlsNXphN2cxNTlYQlJpdXlvRldKa1cx?=
 =?utf-8?B?YXRDRWR5bFUzbk10TkNZZS90WVlVZUtzQTZQbTJkUnFyYnJpc1ljOGJuRm9i?=
 =?utf-8?B?N3o0OHd4QVNLZ0ZyTnU0RC91SGVaTzFQQ05hQyt4N2tKMW9LTFVPQjV4b2wv?=
 =?utf-8?B?M01uQ0lKbSt4Uy9WOWJmbVpDQXo2WW1hNmd3WDFRTnAwMnYyZUhVQ3lkU0dX?=
 =?utf-8?B?ejBiTENVa1VIMEcvREM3T2x0ZFpNUENQTThjLzNjaTNaMXV6ZzNYYmhQc2Jh?=
 =?utf-8?B?Wm5mclorVnk2cnRVM3l2eGJLN1VQZTAzdzRJQUk2aXpaOTZXK1psajlsYzMv?=
 =?utf-8?B?N3RTMFZyL3pEQXlGQk9iRjQ3aDZ2MEQvK1VkbE9nM1pMWkZqWkJNbzAzYWJC?=
 =?utf-8?B?S0JFYjhONXdIS25MemNsN1F5ZnJDYVBBdGVnN3VZdnJRdlhqc3k1eXFxZE1r?=
 =?utf-8?B?OG1uM2Q4UjJOdmZRYnhpUmhaaVV0c3oyYVUvKzJIMmZZanA4N29GaHhSWmpU?=
 =?utf-8?B?UVRjZjBxVGxPbFBIZkpwUmtSdkN4REdzeDBqUjczZVYyVndBQk5kc3pxeE1W?=
 =?utf-8?B?TjNLYlI0UkpKZjMrWmM4TzN5aTlYOUJjYi9TaHNRSzFzbFd1VjdDMmtNNW1s?=
 =?utf-8?B?YWNkcWx3ck00cStxb20rSEIyWG9oMDBwY2g5RHpsNlVidzU5MldMbVhvSEdX?=
 =?utf-8?B?NTd2NUJDOXFjcFNhbVhDQ09HVjhweGxKei8wVVRpUWl4cFBrQzFVT1pqR1l1?=
 =?utf-8?B?Q1JmeVkrTWg0YjlDOEJSWmJuK2xPTmw2Yytua0hzWHFmY0FLMDFqNGx0bnpm?=
 =?utf-8?B?bGdubEJuS3BEM04xWmFXOTVzeGFWYkQ5c3pWU2ZZS0xMYi9tUVhHYW1JalNr?=
 =?utf-8?B?MUVoaVFRZlJ1a0lyZGgyUXpxQjFBNkR5UThkaHYyemEvRXhpRDFBeHBwTWJh?=
 =?utf-8?B?Vy96SmdGTjllUjFOUjAxc1RvTEE3N1BNQ0Z0U2NuQ0N3dnRmNGRyT2IrcnA2?=
 =?utf-8?B?cklTVHhvU3M5S1A1N2daWGgyZnlLZzRlSXprUzFpMmduMlVwRitYaDgraFlL?=
 =?utf-8?B?bHhSMU1xVVVIVmx6dnQ1dSttdFZzSnJyVno1V1dWYmV0ZFNjbmRpUUZtOGpz?=
 =?utf-8?B?MlhER0NzWXpESDdKVURYVXVyKzd4eWI3dk5pYVU4UlN0MGhWYWJxenBQSXNr?=
 =?utf-8?B?alR3Z3luT0FOdGo4REt1S2kwNTNnaVNkd3U1dDlRdXR2a0UzZS9jajU4eENY?=
 =?utf-8?B?WTUzcmdKUWVZbDZUdFBXNDZUaFNIeWN6Q0hRZTJ3NG1qSGZIR0lXNnIyK1dZ?=
 =?utf-8?B?UWU1VW4zdjZ6c2psdldQd0pKQlp2Q2ZYSCtQUVJxV2ZWNGNxT21BWDk1c2tj?=
 =?utf-8?B?K1FzYWZXOWhIQ09uVTNVbkRvUUxqTmVGVFlIVFFzOEpJdjZWVXB5bkVoRFdz?=
 =?utf-8?B?S1hYMGZHTk1WTmFTc2VQcFVaNEp6L0I4aTlWMUlSZENWcytxcStxRU9JTUtN?=
 =?utf-8?B?STBvMTd0ZmsweUdlSkFSN0RiYWs1ZGMvTlZaekxEK1dXNUc0OStnOStFTzRV?=
 =?utf-8?B?eExFbHVSVk1ReG5qR0RrSDFtbmM5d1RmaWpwRUR2RTczSXdLWkV3K2VTMk1a?=
 =?utf-8?B?aTNyYkJ3dkNKZXpxWmZ4bmhGYkN5Rk1XbjQ0ai92eDk1UFdZK0NCMy9PeExO?=
 =?utf-8?B?OEhaSXJLTHpOSUUyQjFLWEcxWnFBODI0S3FSUFlpcG5VTmhXNG1qMVJLbzht?=
 =?utf-8?B?cjBQUXZZdXplZGlYc1JSWTM1TFd5cmx2aTJUL3RzMW5RVkRUUksxc0hiTGVL?=
 =?utf-8?B?cFg0VXJ4MCt3bGtWOVlPKzd1aHBjbHhkNWxERWpBV0ZuaXM0U3BIU1NCVGRv?=
 =?utf-8?B?WFpodmZwa2UwWjV0c1A4Y25KaU1qZjh0T3EvaUt5bHJ1M2VmN2hEWjAwenZj?=
 =?utf-8?B?Nnk2RS9iN2VSMmNkOTN0U0N3cVpTZWc5M3lhNHJLbHQwOGJiaTFBZFhLbHor?=
 =?utf-8?B?Z1plQXQ4djRCZW53MW94QlUyT200MFBuUStpQUc5MTVSV1FoaDhhbHdFcTRF?=
 =?utf-8?B?YU15dW5qMy8vaDFNRldhZkJ6TUc2eVVoY0I0OC9LUVlwejhwN2pVUGFIaHlJ?=
 =?utf-8?B?TS80SEhUa2JMcVo0ZEEvVm84b2FtdXRqdFJWUU1lZFlzUjNkcHJmQjdYb20w?=
 =?utf-8?B?Q2tjZ0F5ckgrakRFczdYS1pVK0lwVmp3ODN2YUtyVkNRTm41N3FVZz09?=
X-OriginatorOrg: ucalgary.ca
X-MS-Exchange-CrossTenant-Network-Message-Id: d64a75f1-8ec3-4f1b-0082-08da32b4673d
X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB3302.CANPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 18:39:23.6555
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: c609a0ec-a5e3-4631-9686-192280bd9151
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gajqkeaHJ4crr1A5WiMCu5l7Rw5tDNRXkzQLWh02yLfcuL16q2MU/QTWn1IE+GKHlp2uqA046WQliiDgIKZoNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB8135
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Thanks Kalle for the comments.

Please let me know if I should resend the patch with the minor changes
or if there are additional comments.

It would probably be ideal if this patch could be reviewed by someone
who is familiar with this device and could provide official initvals
like described here:

https://wireless.wiki.kernel.org/en/users/drivers/ath9k/initvals-tool#synch_initvals_from_the_atheros_hal

I would be happy to test other initvals on my device. The hacked
QCA956x initvals do appear to work stably for me though so this could
be done later.