Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp6249391iob; Tue, 10 May 2022 13:58:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbmRJr7z3FVccCuDuAUUpoEsr2wWBgHh77zl6IwGTXk9579us5Lcez4cHbthrbSaYE9XBt X-Received: by 2002:a17:90b:1809:b0:1dc:1597:20c with SMTP id lw9-20020a17090b180900b001dc1597020cmr1750394pjb.36.1652216309922; Tue, 10 May 2022 13:58:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652216309; cv=none; d=google.com; s=arc-20160816; b=t/UYTBd7lFCQaA6WrgLLXm3IRuzv7MOjEoiCnLLg4+740Wk3bdY6Xsfy4BypbZ7RfL RW/NA4LznoRRebIlVgxmfDU5Olv+aPOmGquKzxzvcrck8nbbPozF3ryTKSpas5m+gKb9 5thx2r5kAWpt4GXMWEX0ks59xEqprjtZ+Mt5jpfRPWsHETnv8gijvuqpn5ojUzTvU6sz xkTiG+0GBik5BnLn8GEhTDCcuEpwN0nabmXHP0h9tR1ZXRuqA9R01hgOB8yOJbbepXVg pYO6BVFiLmL6pKOIMxj5Tcb4rfORTfRrpygtu296X/vHqclH8/JSeWQsZTVAqexO3LXe GAwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=/wrEw/XPtbX7Aa29RfzFLqQ9L9elo+ns/lNVoxwRdQI=; b=eICjVbsNHpWdlGNYfyn72mkF48HuQEWk6a5NqqHnqKujT5cJmwOSDl4R3xLIq6iS1q 4B0UnouXHjVHUf8zcTBcV9cMW86BC8Rbonb9T9FTmPNFSiMJNEMKfYVRc4UXri1gtxB4 2NKbuQg+Iybg8M6/+h3NBxFmy3izTRwSOFeYuJsAxHPlf7IZsSFnoSBWWJ7/r9/3dQOX LPXyN8vNd1N5yz9UHdhr9G3C6xWRFnt+EMWezNoU/FB0LAHA2l98C95rleVT4lK4z8aV t7AyUKucZj4BGArW4OrZgq5Y6whyOiDQpgH0d2zIi16Bz8f/5e59chbybQ5blJeiYKCi o/Gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aPLY6S64; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 30-20020a63145e000000b003a94e627cc2si349574pgu.360.2022.05.10.13.58.18; Tue, 10 May 2022 13:58:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aPLY6S64; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244757AbiEJS3f (ORCPT + 69 others); Tue, 10 May 2022 14:29:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243797AbiEJS3e (ORCPT ); Tue, 10 May 2022 14:29:34 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 040502A7C00 for ; Tue, 10 May 2022 11:25:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A3C88B81F67 for ; Tue, 10 May 2022 18:25:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C364C385D7; Tue, 10 May 2022 18:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652207134; bh=/wrEw/XPtbX7Aa29RfzFLqQ9L9elo+ns/lNVoxwRdQI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aPLY6S64CdECRAhwnpT+P6Lg+3tOjpWl4QS0jzwFkK+G/HKph/VIe4/NGnPV/uy7/ R1M+0fR/DbgwPWTBJm3pGd9t4oKPZmJszTo8jj3DVRtphMPGBH59ylHSj1/Kzx7G0d 5aMXeKTI2AxBSnNfhgQeUyTZNA1gI15cF+eg1dTYb4xTG/DVvvX1SqMsiT92qzQ48J L3epn1xXXlQyRS0Zd72nXdNGyHRAJTBmW00LnxBVOjPM8uivEQzPLzxHFZh3qgx8sz RqhDuWGFjRS7m6AnUDTJw2GGGCOf+8x5NhuOQhdA4nCWg7H/wVDVv34bilE3JbmdrU cfaLbZHICp2lw== Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id E16FA34E33B; Tue, 10 May 2022 20:25:31 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Alexander Wetzel , Johannes Berg Cc: linux-wireless@vger.kernel.org, Felix Fietkau , Alexander Wetzel Subject: Re: [PATCH] mac80211: Simplify queue selection In-Reply-To: <20220510155828.9406-1-alexander@wetzel-home.de> References: <20220510155828.9406-1-alexander@wetzel-home.de> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 10 May 2022 20:25:31 +0200 Message-ID: <8735hhxn1g.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Alexander Wetzel writes: > I still don't understand why we don't want to use qdisc with the iTXQ > drivers. I now just made sure we don't start using qdiscs with this > patch to start with the least invasive approach. Anyone able to shed > some light on that? Because of aggregation, basically. To build an aggregate you need to be able to pull several packets that has the same STA+TID; if all packets on the interface are just sitting in a qdisc you have no interface to do this. Before switching to TXQs, drivers (the ath9k in particular) would solve this by having another layer of per-sta queueing inside the driver, which was just a dump FIFO that added a bunch of latency. The iTXQs moved that up to mac80211, while doing proper queue management (flow queueing + CoDel derived from the FQ-CoDel qdisc) at the same time; this made the qdisc layer redundant for most purposes, which is why we switched to noqueue by default. -Toke