Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a86cae34b3b60ab60bc8c456812e7a115f192e56.camel@sipsolutions.net>
Subject: Re: [RFC] mac80211: add support for 6 GHz channels and regulatory
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Aditya Kumar Singh <quic_adisi@quicinc.com>,
        linux-wireless@vger.kernel.org
Cc:     Wen Gong <wgong@codeaurora.org>
Date:   Mon, 16 May 2022 10:02:55 +0200
In-Reply-To: <1638775571-24366-1-git-send-email-quic_adisi@quicinc.com>
References: <1638775571-24366-1-git-send-email-quic_adisi@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

Hi,

On Mon, 2021-12-06 at 12:56 +0530, Aditya Kumar Singh wrote:
> 6 GHz introduces various power modes of operation. Currently,
> based on the power mode, channel's psd value as well as
> channel disabled flag can change. For single interface, current
> implementaion works just fine. But for multi-interfaces, for
> example AP-STA concurrency, two different channel needs to be
> maintained. This is because, STA power mode also depends on the
> AP's power mode it is going to associate with. Hence, psd value
> and channel disabled flag might vary. In this case, same channel
> can not be used for both AP and STA.


So ... you correctly point out that we need to deal with multiple
interface scenarios.

But we had a previous/ongoing discussion:
https://lore.kernel.org/linux-wireless/20210928085211.26186-1-wgong@codeaur=
ora.org/

> Hence, this patch adds support to store all possible 6 GHz
> channels according to power mode as well as add API
> support for getting chan/freq info from the new struct
> ieee80211_6ghz_channel.
>=20

FWIW, I'm not sure that it's a good idea to have separate channel
structs? Wouldn't it make more sense to have each channel store separate
relevant information regarding the power?


I think you and Wen should go work together and figure out the story as
you think it should be - I don't have a lot of opinion on it, and thus
I'm not sure it's reasonable to ask me to figure out all the different
things.

Please work together and come up with a coherent story of how to handle
this, hopefully including multi-interface scenarios and maybe regulatory
database, internal data structures, etc.

johannes