Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed2d6619d4f5b47582ba5edd0751eb16c18b5747.camel@sipsolutions.net>
Subject: Re: [PATCH v4] cfg80211: additional processing in
 NL80211_CMD_SET_BEACON
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Aloka Dixit <quic_alokad@quicinc.com>
Cc:     linux-wireless@vger.kernel.org, kernel test robot <lkp@intel.com>
Date:   Mon, 16 May 2022 09:53:49 +0200
In-Reply-To: <20220509225237.15955-1-quic_alokad@quicinc.com>
References: <20220509225237.15955-1-quic_alokad@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-05-09 at 15:52 -0700, Aloka Dixit wrote:
> FILS discovery and unsolicited broadcast probe response transmissions
> are configured as part of NL80211_CMD_START_AP, however both stop
> after userspace uses the NL80211_CMD_SET_BEACON command as these
> attributes are not processed as part of this command.
>=20
> - Add the missing implementation in nl80211 and mac80211.
> - Modify the local variable in nl80211_set_beacon() and input parameter
> to rdev_change_beacon() from type struct cfg80211_beacon_data to
> type struct cfg80211_ap_settings to support the new processing.
> - Modify ieee80211_change_beacon() to reflect the new input parameter typ=
e.
> - Modify driver specific functions pointed by change_beacon to
> reflect the new input parameter type.
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com>
> ---
> v4:
> - Modifications to all driver specific function pointers.

That's fine.

> - Also included all files in a single patch instead of splitting as per
> the modules because otherwise compilation fails with changes in only
> net/wireless and include/net directories.
>=20

That I prefer not. Please send the mac80211 (and/or driver) changes
separately (make sure you edit the commit logs appropriately), with the
first cfg80211 change only containing the API updates across the rest of
the tree.

johannes