Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3712f8f1-f36e-23e5-d3bd-fb5b77457c7e@candelatech.com>
Date:   Mon, 16 May 2022 18:26:28 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 2/2] iwlwifi: RX signal improvements.
Content-Language: en-MW
From:   Ben Greear <greearb@candelatech.com>
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
References: <20220225232842.32028-1-greearb@candelatech.com>
 <20220225232842.32028-2-greearb@candelatech.com>
 <175612fa5385cf2c30207df9012074df2c65f551.camel@sipsolutions.net>
 <d93c5295-d57d-9352-a484-548da937fb1a@candelatech.com>
Organization: Candela Technologies
In-Reply-To: <d93c5295-d57d-9352-a484-548da937fb1a@candelatech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/4/22 07:46, Ben Greear wrote:
> On 5/4/22 3:57 AM, Johannes Berg wrote:
>> On Fri, 2022-02-25 at 15:28 -0800, greearb@candelatech.com wrote:
>>>
>>> -    if (mvmsta->avg_energy) {
>>> -        sinfo->signal_avg = -(s8)mvmsta->avg_energy;
>>> +    if (iwl_mvm_has_new_rx_api(mvm)) { /* rxmq logic */
>>> +        /* Grab chain signal avg, mac80211 cannot do it because
>>> +         * this driver uses RSS.  Grab signal_avg here too because firmware
>>> +         * appears go not do DB summing and/or has other bugs. --Ben
>>> +         */
>>
>> That "--Ben" really seems inappropriate ... please take more care when
>> sending patches to the list.
> 
> I figure if I am submitting a patch that is blaming firmware, and I have no access
> to firmware to actually back up my assertion, then I should put my name on it
> so that folks looking at the driver don't think it is Intel disparaging it's own firmware.

Hello Johannes,

If there is no reasonable chance to make changes like this to iwlwifi (lockless
signal averaging is the unfixable part I think), let me know
and I'll consider the issue closed.

And, in that case, the mac80211 patch is un-needed since no driver that I know of
would need that code.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com