Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c41731aea4fc043bad1ab6db724c2283df0a3d42.camel@sipsolutions.net>
Subject: Re: [PATCH v5 1/3] cfg80211: additional processing in
 NL80211_CMD_SET_BEACON
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Kalle Valo <kvalo@kernel.org>,
        Aloka Dixit <quic_alokad@quicinc.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Tue, 17 May 2022 12:50:24 +0200
In-Reply-To: <87v8u4wyw4.fsf@kernel.org>
References: <20220516202454.4925-1-quic_alokad@quicinc.com>
         <20220516202454.4925-2-quic_alokad@quicinc.com> <87v8u4wyw4.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-05-17 at 07:45 +0300, Kalle Valo wrote:
>=20
> > +++ b/include/net/cfg80211.h
> > @@ -4200,7 +4200,7 @@ struct cfg80211_ops {
> >  	int	(*start_ap)(struct wiphy *wiphy, struct net_device *dev,
> >  			    struct cfg80211_ap_settings *settings);
> >  	int	(*change_beacon)(struct wiphy *wiphy, struct net_device *dev,
> > -				 struct cfg80211_beacon_data *info);
> > +				 struct cfg80211_ap_settings *info);
>=20
> Shouldn't patch 3 folded into patch 1? I don't see how patch 1 as is
> would compile without warnings.
>=20
Yes, and parts of patch 2 as well.

johannes