Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3992593iob; Tue, 17 May 2022 11:22:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIxt3yRJw8Eu7udnUVaIng79y8oHq4706Gs9W3z0WYghUoMzaQ95BrHYuBfNZdo2dlN1gF X-Received: by 2002:a17:907:868e:b0:6fe:293:e7cc with SMTP id qa14-20020a170907868e00b006fe0293e7ccmr18815366ejc.716.1652811768200; Tue, 17 May 2022 11:22:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652811768; cv=none; d=google.com; s=arc-20160816; b=Bs29ejnrdCd0Qd9nlB2EblQwj062V/iw8ocgyqnxxIU+0lxOP4n3KDP5p5/f85vY1/ gRVSbSYgoPyRR8TgyQiWfYn8PLUC6YZklNJZ/ernTGTPfMyRZW6hbbxyiYh2aaXx9hb7 kIlYTtqMsc/3uIZ+L/Gi/6CMsOfkP5OpAAz7JCvQaEixuDGQmX4MIkIOMbWj385nrENk ovr/brrokQ8tfvboZTitSiJKILpaWkG/mtIw+ij70dmmzQLRZzxtzk0qUoCcf1JU9MFD Q+dyJ8enOa5/ymn/VDUd+1eSzMKKII8jBfdes1q8PMLBEwAbrJ24HZ0r43Uw+i9Fhyc5 qtow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=wsX2/1ZAuqjaHe5AUtUsNOh95L69Lbj7eZkH1APfFlk=; b=u3xaPbcNhfyWUy1lLuhM9SJSkpnbkXHj1Eq7Slp9HhVvR93yABWAmznSd1k5pzxYIH 3w8A9GUep6CEdU4FPLmqGukvEMMU2b3Mo8My9FN7coLDXbpAIjjS6OME8rNwJePFyAdX errNjC4iul5ZQLa0Vawetodo6E7UoWKYdUuSR5qruYr+d1fnFXU6rDy+osUfmXLNERUk C2iVfN/oGKBxQJEk971Q8cw67gv5BofPfolgNQvsE/yDgmatZvmWa2azqzSEmdqKuSRd Z0ji/Ld/CUZuVQnIHt1DzS7rFVQRH6FE1ocf+o/I/BrmlnzyKbSX1KcXJZpnDKdCH799 OMYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qVBFvUaz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb1-20020a1709071c8100b006f3a0ad9695si29065ejc.81.2022.05.17.11.22.28; Tue, 17 May 2022 11:22:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qVBFvUaz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243835AbiEQRcI (ORCPT + 70 others); Tue, 17 May 2022 13:32:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbiEQRcH (ORCPT ); Tue, 17 May 2022 13:32:07 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8100438D91; Tue, 17 May 2022 10:32:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3B384B81B2F; Tue, 17 May 2022 17:32:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DE9EC385B8; Tue, 17 May 2022 17:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652808723; bh=NuGBigtyGKPXWM/MaUlUZBG/HmD7xPOta8lEUkmex90=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qVBFvUazhsMIfj1pq7ETdVEoefWaS76SV63TUTf1coelXoWWkpalWhLKM29j2Fzoe vGRMEQ2619Ac8qIs1iRMUY/y2jyTYP7dKO7wEWZcMiswmUGRQbxhBa2ovTiBY9BadF imlibOD7C5l9QrXcmsk7FwU8mDo17RyswZHX3woicUYa0RPPOBlZO8yKUjwswPpZd1 rOpVKpgAVcixZVnuIX7SlJUNmPBExMnue8iblSy201Ixn4zAnk6gWIomXpGof0RaFc g6Lh/QKQHnj8JjlnnLb2zv1dMjfXcPqSYlnUI/Xu+/4mqfC0wrsYImiVfEH93RGpT/ yJ+cX/Tp0I5CQ== Date: Tue, 17 May 2022 10:32:02 -0700 From: Jakub Kicinski To: Kalle Valo Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, johannes@sipsolutions.net, alex.aring@gmail.com, stefan@datenfreihafen.org, mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc, sven@narfation.org, linux-wireless@vger.kernel.org, linux-wpan@vger.kernel.org Subject: Re: [PATCH net-next] net: ifdefy the wireless pointers in struct net_device Message-ID: <20220517103202.6613c5ef@kernel.org> In-Reply-To: <87zgjgwza1.fsf@kernel.org> References: <20220516215638.1787257-1-kuba@kernel.org> <87zgjgwza1.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 17 May 2022 07:36:54 +0300 Kalle Valo wrote: > > +void cfg80211_unregister_netdevice(struct net_device *dev) > > +{ > > + cfg80211_unregister_wdev(dev->ieee80211_ptr); > > +} > > +EXPORT_SYMBOL(cfg80211_unregister_netdevice); > > Why moving this to a proper function? Just curious, I couldn't figure it > out. Sorry, I went too far with the "explain what not why". The header is included in places which get built without WIRELESS while the C source is not.