Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 12:29:40 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
        pabeni@redhat.com, Stefan Schmidt <stefan@datenfreihafen.org>,
        alex.aring@gmail.com, mareklindner@neomailbox.ch,
        sw@simonwunderlich.de, a@unstable.cc, sven@narfation.org,
        linux-wireless@vger.kernel.org, linux-wpan@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: ifdefy the wireless pointers in struct
 net_device
Message-ID: <20220518122940.6f4da4a8@kernel.org>
In-Reply-To: <d161164cbb1d048ce1b2d99d23ed87c605cfaa8c.camel@sipsolutions.net>
References: <20220518181807.2030747-1-kuba@kernel.org>
        <d161164cbb1d048ce1b2d99d23ed87c605cfaa8c.camel@sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 18 May 2022 20:59:21 +0200 Johannes Berg wrote:
> Acked-by: Johannes Berg <johannes@sipsolutions.net>

Thanks!

> Do you want me to follow up with trying to union the pointer into
> ml_priv?
> 
> I prefer to union it rather than use ml_priv because we'll not want to
> use the getter everywhere when we already know, only on the boundaries.

Your call. Replacing all the direct references with a helper call could
indeed be onerous.