Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1786604iob; Thu, 19 May 2022 14:47:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwamaEpCgaTqoo37hBUwJ9kaBKaIbl9ONL28a994nqyeAKGT71UFwzQmNyKOcJps6JV3oyM X-Received: by 2002:a17:906:3b8d:b0:6fe:94ac:2a78 with SMTP id u13-20020a1709063b8d00b006fe94ac2a78mr6286305ejf.547.1652996830832; Thu, 19 May 2022 14:47:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652996830; cv=none; d=google.com; s=arc-20160816; b=ldAqykLgb5OupFrezE49qfj1a+hD/zXbfpOv31UgMDxs/10cySz9XQrkL9KQ9ZzzYE 6Zyt0vcoppKH9Kd1JbtkusFC8JXz8d+c2QVTVmpqIz9ez5VcORgJ+aF82ZxMU4kDeyQW 3QN6RR+Deww2UBULTn24Xq8KK0BnG0wCmI3mU72/d46QJb39QnZGJWm43ST9KoOsdTdW yJFouGpqjrvVBONksS4aOYlAvKw0OKtWaSSLgT0HADKFsv74yVxI8Pl83nCC4PSUEdc7 4jjyzbnSda1+ZVKOrouYFkAU87kX7OzDw38VFX3D/4JoNomhjzoW8FCuAvzuWIhZzhTS kSfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ezlFNIw1YV6/IbC1LgUXiEe8pIzsUQQCD7W/6KfdQOQ=; b=QZXMQsqRpOfOwzTqB3ie3+IrXchvWv4n51VolspYJWpR5MZ14ZkZtePcRUyXIiGKzC paiP5Sf+TwWTB5N8USFMdfhm6qAizde36TwkHquV3TwFvMCz6omWCKb1sLcPHOCNcjnj dELl8ttkzKZzLmhi34yGSC5fUi1ixT3fvXFTlBrIHzyPnlVwVdd8LMhz0TkWtqecPq38 DNrCp4XnSIZROmuX9q5ausrHl2iMQ0i329t2iNiXW67xdnVx/lHy+Fe74bYhNc6pgL5h LTIVcyEade3Y0c9KS4TY0I3zwowgRGo5qFlu6U73ReQSU3VK08KKkR4rI84C+m0xAXSk DejQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b="ygvkjK/p"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r6-20020aa7d146000000b0042ac59b7688si5537905edo.403.2022.05.19.14.46.46; Thu, 19 May 2022 14:47:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b="ygvkjK/p"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239647AbiESPwu (ORCPT + 69 others); Thu, 19 May 2022 11:52:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238806AbiESPwt (ORCPT ); Thu, 19 May 2022 11:52:49 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16BDC62129; Thu, 19 May 2022 08:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1652975567; x=1684511567; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ezlFNIw1YV6/IbC1LgUXiEe8pIzsUQQCD7W/6KfdQOQ=; b=ygvkjK/p9ql3ncXECqxnuOJTWK5JE7oqDpBcL6TRyCXtLhxUQsvJtk8H ocYyBR6MgjkXUkUjNB/bzoHLOVHC74cIru8mLJ5nFOrcE2s6PTWGFpCVx outXibwSHJhk9bh/Cn13AiQPils1sVTh6dcjmKkLuKNckrmP44WHiP/oo 0=; Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 19 May 2022 08:52:46 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 08:52:46 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 19 May 2022 08:52:45 -0700 Received: from [10.110.66.23] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 19 May 2022 08:52:44 -0700 Message-ID: Date: Thu, 19 May 2022 08:52:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] mwifiex: Fix potential dereference of NULL pointer Content-Language: en-US To: Kalle Valo , Yongzhi Liu CC: , , , , , , , , , , , , References: <1652957839-127949-1-git-send-email-lyz_cs@pku.edu.cn> <87r14p1qkw.fsf@kernel.org> From: Jeff Johnson In-Reply-To: <87r14p1qkw.fsf@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 5/19/2022 8:37 AM, Kalle Valo wrote: > Yongzhi Liu writes: > Format is wrong, it should be: > > Fixes: 21c5c83ce833 ("mwifiex: support sysfs initiated device coredump") And no blank line between the Fixes tag and the Signed-off-by tag