Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   viktor.barna@celeno.com
To:     johannes@sipsolutions.net
Cc:     aviad.brikman@celeno.com, davem@davemloft.net,
        eliav.farber@gmail.com, kuba@kernel.org, kvalo@codeaurora.org,
        linux-wireless@vger.kernel.org, oleksandr.savchenko@celeno.com,
        shay.bar@celeno.com, viktor.barna@celeno.com
Subject: Re: [RFC v1 000/256] wireless: cl8k driver for Celeno IEEE 802.11ax devices
Date:   Sun, 22 May 2022 20:51:19 +0300
Message-Id: <20220522175119.285719-1-viktor.barna@celeno.com>
In-Reply-To: <4526c9fb8269675a98845160d15d4b746ae3b62e.camel@sipsolutions.net>
References: <4526c9fb8269675a98845160d15d4b746ae3b62e.camel@sipsolutions.net>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e+hoC5nS6cwTHzvpTp3HTFPA1nZd/P/o0HED76n6ADiNsrD3W8rUNCVdxkgj?=
 =?us-ascii?Q?3AoRcKZkT+3yrtG4xAiNM3UQ6xLS9IZ1+krK0+eh7sM2XE85ZeNu8e1rrvC5?=
 =?us-ascii?Q?HuOzq31xxfH2bRC/zsqEtAYNRw0vlRmriJnTdyyDt1iGVnRFmXKOGSm6XzAH?=
 =?us-ascii?Q?26yekTKRmtNtlgDRiOuPZ43bH5KTq0UR1tYqgvnl2h1ZCEMuxP7ZyBZVMBdU?=
 =?us-ascii?Q?fqdIKV788xxsgfyJKVGOiJ3b1DQAMdVaqtN4dDiuRkpAIsVw7YS1IZTrIBoD?=
 =?us-ascii?Q?H3IqYX0sQbyXCrVH060Mv+Xb5+3LT9kCqYplBar8SzpZrFgo2TnBO6cMVufL?=
 =?us-ascii?Q?OxsgSk+hG6fw8fI7RbO3S0A/LXSPiquHPmwip70QGGVPLx1bANd4ynxIyIJS?=
 =?us-ascii?Q?+gLsthyBs8VAINDe+VVDGZJvWghYBqrQFNUjgX2r2PMEY53V0qx6xToRq+y3?=
 =?us-ascii?Q?/LMOMDsIu/JiLamv2fHxBRpQCCDO3DXuCA1odVoess5hrozcE2Nal2AxjnOD?=
 =?us-ascii?Q?zSIQJ4IluTRcP0csE53n6FYGdHrVvIwf7pp8cXO6lBVTHGxCf2aDJCuBxP4P?=
 =?us-ascii?Q?Cv1Spv8YEEUqM0iTjye2gBswdI4fNjbBzvqlbMkBe5r+zgS4vIr/KK6NXvAE?=
 =?us-ascii?Q?5QP99Zdj1yrtfndwt3xTiT+kuwaQKOjHWWIeq68Ifgv4ll9dlQF2n64HVQzV?=
 =?us-ascii?Q?q+drzXvTlV2Ti47gVjlcAPOjonEH6qxtJGIvJLPeiLSX7c7QbUtT9vy2zi/6?=
 =?us-ascii?Q?xAVn3aVvXylNHJtBMzc4AHqrJZZSiWbZpxyy8F/jjxxa5vlzk4j0fgpBmreo?=
 =?us-ascii?Q?exv4HjaumAiBbUpWRCP3QYFTXKsZU9NwC3vlAmw1aHvW1SAog9Pq/DQ7Odjp?=
 =?us-ascii?Q?NxPdMPkX1zDSQYqfjpYRV5CQbAzM5sQT6YzxhbunlBklfdxHr55ZkDnmYkSp?=
 =?us-ascii?Q?42oQHTJueDeldAf5sYD0RLwoaVwiXqqevp3fuUzW+Fn2n4RlkjZXBcGEqmsb?=
 =?us-ascii?Q?RgawT/vpbJdH+iKFzyrlP3B915l7vD2HH/4UXouzujfzWxosaILSaQSYoa15?=
 =?us-ascii?Q?IFpicmNYPZQYIXVKtloyAPSoIm8WmSsl0GS1E6VkRf1P9UGmjHxnlDrxiQ+0?=
 =?us-ascii?Q?U7uG/wLohrdJeKiSImSTbzFG70FyCD/RKLIsSlEBJQShCT3XybkrJ065kftX?=
 =?us-ascii?Q?hufZqumMLoMjLyM+eJnHFn2mboG7+VCfYoUBwDcKdnXmsq/5O4WTe8okvyjt?=
 =?us-ascii?Q?UkhTRMXlKLRQ+5xDkI0EYmQG0qdYbEAAuqk4kX+L68agWCfwpElfQmv+tfwo?=
 =?us-ascii?Q?II9bCqhOeIOWzAhpGmbP1yBEvQMON0LxzkL6vpo/CdlLpNmrf3zYC0ueEz7j?=
 =?us-ascii?Q?MVNpwoTWWMt7PnMshmTVEb+QZByhZd9Hn9bTjCIP8BllX/mGrlmbZmEhN+bq?=
 =?us-ascii?Q?e4JlopC+a1NhESV9E89Rus8HgL2iK89q5kHLqzMcGr61zMEQnnhf+nWxY99+?=
 =?us-ascii?Q?/IDXmrs6m8WP9rcdYwp3gr0o26Xbod200ZbFiBl3NwU7TQ7eDvv7NzEEZvjv?=
 =?us-ascii?Q?/I7okb0fqPtctrT9nmBYWoxwkxkVR6d5ud+kS2aRKbQvB3rMr79VU1HCCYAW?=
 =?us-ascii?Q?5tHYvOBqD0WdseexB24r0JH8q5kGUe8iLKNE5XK2sK0tMkCKRSPQlrxJwoKZ?=
 =?us-ascii?Q?2IaHJfl3nxHQs0/b20Ts2DRrDC/TrnbOInVxUvathnZjtXQrLGlpXUdSp359?=
 =?us-ascii?Q?weAOdYBQEoyF/maDcwjzvpzPmxVIxu8=3D?=
X-OriginatorOrg: celeno.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9f512d2-50c3-48cc-1c95-08da3c1bb6fc
X-MS-Exchange-CrossTenant-AuthSource: AM9P192MB1412.EURP192.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2022 17:51:36.0917
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f313103b-4c9f-4fd3-b5cf-b97f91c4afa8
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0USjdzBZwg4G4AJY0cLgzkg49BCSFPO/vvk3my81THzS2g+CkgpTsvzmRJzzCe1Aw0a70o7jZ7bzU02PEMN3Yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAP192MB0987
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi Johannes,

we are very grateful for the initial review and a big sorry for such a
prolonged delayed response from our side - we were working on minimizing driver
and RFCv2 is almost ready.

> * without command line interfaces with string parsing built into the
>   kernel
>   (OK, that's probably something that will never go upstream anyway)

RFCv2 will contain removed CLI, some of the stuff moved to the debugfs
(because in most of the cases that's only debugging commands), but we will
publish that patchset even without that - to have as minimum solution as
possible (as it is also required in the guide). Some time later we can
re-introduce the debugfs solution in the future after aproval of base driver.

> * Kconfig vs. code inconsistencies cleaned up, you have a TON of
>   CONFIG_* ifdefs that don't even exist and can never be set, so remove
>   the code, at least for now?

ACK. Unused defines were removed, and others were refactored in a way, that
allows to tune them via Kconfig.

> * remove wrappers like cl_snprintf(), though that seems part of all
>   those command line interfaces built into the driver

ACK. RFCv2 will be without them at all.

> * consider joining some of the many header files into bigger chunks,
>   header files that are 50% boilerplate aren't really all that useful

ACK. RFCv2 consists of ~98 files now (functionality was merged by some similar
area - like all the TX in tx.c, all the RX stuff in the rx.c etc). If that is
still huge - please, feel free to comment. Maybe, there is some acceptance
criteria? It looks much closer to existing drivers. If the number is still high,
just for the sake of review we can merge header files into bigger pieces.

> * namespace your things better - e.g. "is_ipv4_packet" and friends?
>   (why do you even care?)

ACK. That case was related to the lookup of time-sensitive traffic - to avoid
putting it in the slowpath.

> * remove all vendor commands for now, and read the vendor commands
>   upstreaming documentation before re-introducing them
>   https://wireless.wiki.kernel.org/en/developers/documentation/nl80211#vendor-specific_api

ACK. All the netlink will be removed in RFCv2.

> * remove utils/string.c, obviously, use kernel stuff directly or
>   improve where needed I guess - but likely all part of the weird CLI-
>   in-kernel stuff?

Yep, you are correct, in most the cases, custom abstraction was part of the CLI
(and configuration parsing). It will be removed in RFCv2.

> * remove abstraction layers like cl_timer

ACK.

> * what's this VNS stuff? doesn't look like it belongs into a driver
>   (a mac80211 one at that!)

Very Near STA - extra functionality, that allows to tune TX power regarding STA
position. We can move it out temporary since it has bindings to the FW and
reimplement in the mac80211 if there is necessity.

> * bitfields in endian-safe code are generally frowned upon, so you
>   shouldn't need cl_are_host_bits_le(). And also cl_are_host_bits_be()?
>   What?

cl8k driver is using dev_coredump subsystem for dump preparation, and these
functions were part of dump information about the host - it could be useful for
postmortem analysis of the dump themselves outside of environment where they
were collected.

> * Use ERR_PTR() and friends, instead of out pointer parameters.

ACK. We will take it into account during RFCv3.

Again, thanks for the initial review!

PS: Mr. Kalle confirmed, that disclaimer issue is resolved, that is good,
thanks!

Best regards,
Viktor Barna