Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp3265715lfo; Mon, 23 May 2022 00:18:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOk2UPnyxRIWU4O3iV570qEqqOz2XwMkkdQ+K+tKIPPb7MHYdpvsRIqBEI1soxnr29d/MQ X-Received: by 2002:a17:902:e88d:b0:161:cf94:6000 with SMTP id w13-20020a170902e88d00b00161cf946000mr21605495plg.62.1653290296379; Mon, 23 May 2022 00:18:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653290296; cv=none; d=google.com; s=arc-20160816; b=pq0bjsHOumTRRD6Z8EKX3n3QAz/OXWOLxcixezcUOLRFrzHTB1RsfqWpNZjuKv5eyu pWTNDc1JH5o3EpGPV4tHySldG1sTd3gGiWkDDGbqkjfEtlmzRPj0vkn4fd6HUQJsbRcj UcJH/+kJt0KzyTG0gKXHhkbEDeh6ktmzLPUacElnJT8RVnJlBH+3D2UtHIZfDxT7GD3V 13CeTh36XqLAoOl2UnYfszwTgh+pp96l1baKl4a6fyjFho1hpqvOwZmmB6x0l597i8gm 7a5269O2rxj6O//hDO/hiHBLvU5oVtFZ1tv++je5uhaVjNIVhk6gSJr5U8arQZigM/Fc xCdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=qFyHLWiJFkbtsc+07ONTlLUDErGppQM5kcz2Kw4ikYQ=; b=bkUH+YYDzb6S3yiMZ5i8Nwr1asOwEHZVIF3vZQgMtq6Pl0R4pZ1sEZEPqhT5vDzvID dvOEatClUQGwkzpW7s1Az2ZcB91VVrrbWkuOO7BcKJMgdPO7MeRf1EANiKQg0YpjOpzf r/wS7ZUVZStBTJynwHowkzl85W7mTvEvC7nPTTpvKTixmMRqw2774wgnhS56iQxXf5NC 2eYcXcG3bVvOxNyDFmkjDjuiAazcykeeezjs9DzmUqZoPhTR0AjB/vkzvzNMw/rAwbuE lz6xXqK1msX3zu11JTMhPB3yEml9bFeAJzYCXYgDs1NUPGRQl11DNTJOEod5ovfj/xfA lTTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oWGa0P0x; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b15-20020a63d80f000000b003fa387a7f01si4404996pgh.158.2022.05.23.00.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 00:18:16 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oWGa0P0x; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4442048E7B; Sun, 22 May 2022 23:35:44 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343782AbiEVM3L (ORCPT + 68 others); Sun, 22 May 2022 08:29:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243025AbiEVM3J (ORCPT ); Sun, 22 May 2022 08:29:09 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FB353CA65 for ; Sun, 22 May 2022 05:29:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0F075CE0ACE for ; Sun, 22 May 2022 12:29:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93D59C385AA; Sun, 22 May 2022 12:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653222545; bh=TTwbaWYmNhgxiA2PEesTWAdjhrl9YmH717xkWYfvxco=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=oWGa0P0xDhe/Utv0yFmPrBBhs0UnOj5pEKQ3eW0m4WUtLm/Wrpn0Z7L1vj4xpyIeo dhhMDmD4hDKX0UxE2zrl/qWWGchYg7vV7RG+F3eu1iJzW0EftDsSPHoCLOodEnWZyW 4+adJ30P7ulCPoUk5OHHcsXrcuHlpdcHi0Mr0cpJ3TWq+VxDzDZ7fNSKEDmBaHN9uS OJUz3ay3xv3GyzaBPbewPZexjgk8GCctk4Nc9fuJM8TNE92tGG7WV2eiDicrFe4Ln0 r0JOmkcRlvyU/9seAPilsWPIFxr0+qkMKwjYcTbyyoEz8NQ373I3U2kLTz5777zcL9 qcOTmB4FYmgdA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: Fix warning on variable 'sar' dereference before check From: Kalle Valo In-Reply-To: <20220517004844.2412660-1-quic_bqiang@quicinc.com> References: <20220517004844.2412660-1-quic_bqiang@quicinc.com> To: Baochen Qiang Cc: , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <165322254267.774.12155186929267464272.kvalo@kernel.org> Date: Sun, 22 May 2022 12:29:04 +0000 (UTC) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Baochen Qiang wrote: > We are seeing below warning: > warn: variable dereferenced before check 'sar' > > Fix it by moving ahead pointer check on 'sar'. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 > > Fixes: 652f69ed9c1b ("ath11k: Add support for SAR") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Baochen Qiang > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 77bbbd5e0ed3 ath11k: Fix warning on variable 'sar' dereference before check -- https://patchwork.kernel.org/project/linux-wireless/patch/20220517004844.2412660-1-quic_bqiang@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches