Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <12c8d629-86b0-1cd9-18f2-eeafccf36714@quicinc.com>
Date:   Mon, 23 May 2022 18:57:36 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v3] cfg80211: Increase akm_suites array size in
 cfg80211_crypto_settings
Content-Language: en-US
To:     Jeff Johnson <quic_jjohnson@quicinc.com>,
        <johannes@sipsolutions.net>
CC:     <linux-wireless@vger.kernel.org>
References: <1653024702-5304-1-git-send-email-quic_vjakkam@quicinc.com>
 <a8a3b56b-5e82-28cb-bd61-e338bae25df2@quicinc.com>
From:   Veerendranath Jakkam <quic_vjakkam@quicinc.com>
In-Reply-To: <a8a3b56b-5e82-28cb-bd61-e338bae25df2@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/20/2022 9:45 PM, Jeff Johnson wrote:
> On 5/19/2022 10:31 PM, Veerendranath Jakkam wrote:
>> Increase akm_suites array size in struct cfg80211_crypto_settings to 10
>> and advertise the capability to userspace. This allows userspace to send
>> more than two AKMs to driver in netlink commands such as
>> NL80211_CMD_CONNECT.
>>
>
> I have some grammar nits below...
>> This capability needed for implementing WPA3-Personal transition mode
>
> capability *is* needed
>
>> correctly with any driver that handles roaming internally. Currently,
>> the possible AKMs for multi-AKM connect can include PSK, PSK-SHA-256,
>> SAE, FT-PSK and FT-SAE since the count is already 5, Increasing
>
> ...and FT-SAE. Since the count is already 5, increasing...
>
>> the akm_suites array size to 10 should be reasonable for future
>> usecases.
>
> /jeff


Thanks Jeff. Fixed the suggested grammar nits in v5

--

veeru