Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp3601093ioo; Wed, 25 May 2022 04:22:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1Jv+Wwaa3c83/ZI2RUc+7PvGDJTwMH9+vrW1JWoWKnJEFdfUrVNptNH95bAdd8FcNobK6 X-Received: by 2002:a05:6402:2815:b0:420:c32e:ebe2 with SMTP id h21-20020a056402281500b00420c32eebe2mr34239501ede.1.1653477725849; Wed, 25 May 2022 04:22:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653477725; cv=none; d=google.com; s=arc-20160816; b=s/h2vMLPbVxUoXI/KK6Y30gsD5YxOpQgv0uIHXCaH4GEt2zjA9RYr6orki2kFN2izu GrId3O7OSq/2oPcZag1s5apzosN5mNftWXje4VQ7I+M3S85Q6/NGHk+6zbc1COobdJmE FHHOgL5K8jIOEh0/bbv2aZx/IR4ucLQ5P4kiAiyUTHNHHQIpOS6OTFQI2lLzu/CMyxzO sLRUMxLRefJdO8Avz6UMrc7qlaQUjzCUIfVHrstEJh94rFvy6wDor4jX6oHWnHARKP+b XkclfR6hUvL68L48CUj7cYxQbz9t7rQ56E8VT4f+TCpiGejMetsNjzxuB1bikCHTCJFO 6ATA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:authenticated-by; bh=xaVC0+//v65+eFGMzAYoZWhyU5h3AgvHjv94Q9/PFoQ=; b=vDoxEXPXRdg1QJulrIijMCmLmP0GShszginx/NwpdOiOWkx2V/RPaF3UbeJVpMke8F i9wJMOJPQyEE2Dr5aPOOa9ZeEdocSBOPizNcGgNGKnc7vsO/WQFsKpmNeNVxO+ZOBije lRb5PR5OhpxzF36rdCk8ROVhKryajiHIMxBPCKwopXed1wfRWQalGTZ/hvqWTtFXqpEp 9mHGPCOAOlymv36Bx6Q7zUy200z16WQSTCG4tccFutmNd2wnz3/pxkKiDCtBYdMvXeNT Mtd2P9gSytwG84HPYNAau9hI+fN9HyGtwdggByuoFJ+GaJyKEW7UsCiFKuOuvGXZoj9A HNuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ee56-20020a056402293800b004262b42b2b7si12841222edb.602.2022.05.25.04.21.36; Wed, 25 May 2022 04:22:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242891AbiEYASg convert rfc822-to-8bit (ORCPT + 67 others); Tue, 24 May 2022 20:18:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236535AbiEYASc (ORCPT ); Tue, 24 May 2022 20:18:32 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF7A970901 for ; Tue, 24 May 2022 17:18:29 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 24P0I8Lh8011341, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.71/5.88) with ESMTPS id 24P0I8Lh8011341 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 25 May 2022 08:18:08 +0800 Received: from RTEXMBS02.realtek.com.tw (172.21.6.95) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 25 May 2022 08:18:08 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS02.realtek.com.tw (172.21.6.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 25 May 2022 08:18:07 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::34e7:ab63:3da4:27c6]) by RTEXMBS04.realtek.com.tw ([fe80::34e7:ab63:3da4:27c6%5]) with mapi id 15.01.2308.021; Wed, 25 May 2022 08:18:07 +0800 From: Ping-Ke Shih To: Larry Finger , Kalle Valo CC: Johannes Berg , "linux-wireless@vger.kernel.org" Subject: RE: [PATCH v3 0/4] rtw88: Fix some Sparse Warnings Thread-Topic: [PATCH v3 0/4] rtw88: Fix some Sparse Warnings Thread-Index: AQHYb4QULME5rGflWkCKqtZfeI3TwK0uun2A Date: Wed, 25 May 2022 00:18:07 +0000 Message-ID: <206309821b8148bbb194c7d08a00d708@realtek.com> References: <20220524153621.19027-1-Larry.Finger@lwfinger.net> In-Reply-To: <20220524153621.19027-1-Larry.Finger@lwfinger.net> Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.69.188] x-kse-serverinfo: RTEXMBS02.realtek.com.tw, 9 x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering rules found x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2022/5/24_=3F=3F_10:18:00?= x-kse-bulkmessagesfiltering-scan-result: protection disabled Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > -----Original Message----- > From: Larry Finger > Sent: Tuesday, May 24, 2022 11:36 PM > To: Kalle Valo > Cc: Johannes Berg ; linux-wireless@vger.kernel.org; Larry Finger > ; Ping-Ke Shih > Subject: [PATCH v3 0/4] rtw88: Fix some Sparse Warnings > > Sparse shows warnings for symbols that can be static. In these cases. > the wrong solution is suggested - again reinforcing the concept > that all tools may suggest the wrong answer, and must be checked. > > Constify all *_hw_spec variables > > Signed-off-by: Larry Finger This patchset looks good to me. Thanks! Acked-by: Ping-Ke Shih