Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <720c910a-9237-9229-901c-fd8f374a13cc@quicinc.com>
Date:   Wed, 25 May 2022 11:39:05 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [RFC v2 19/96] cl8k: add def.h
Content-Language: en-US
To:     <viktor.barna@celeno.com>, <linux-wireless@vger.kernel.org>
CC:     Kalle Valo <kvalo@codeaurora.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Aviad Brikman <aviad.brikman@celeno.com>,
        Eliav Farber <eliav.farber@gmail.com>,
        "Maksym Kokhan" <maksym.kokhan@celeno.com>,
        Oleksandr Savchenko <oleksandr.savchenko@celeno.com>,
        Shay Bar <shay.bar@celeno.com>
References: <20220524113502.1094459-1-viktor.barna@celeno.com>
 <20220524113502.1094459-20-viktor.barna@celeno.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20220524113502.1094459-20-viktor.barna@celeno.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/24/2022 4:33 AM, viktor.barna@celeno.com wrote:
> From: Viktor Barna <viktor.barna@celeno.com>
[snip]
> +#define ASSERT_ERR(condition) \
> +	do { \
> +		if (unlikely(!(condition))) \
> +			cl_dbg_err(cl_hw, ":ASSERT_ERR(" #condition ")\n"); \
> +	} while (0)
> +
> +#define ASSERT_ERR_CHIP(condition) \
> +	do { \
> +		if (unlikely(!(condition))) \
> +			cl_dbg_chip_err(chip, ":ASSERT_ERR(" #condition ")\n"); \
> +	} while (0)

Again you have macros with magic names cl_hw & chip