Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1e7d525f-b080-1ee4-3446-c29d1278ffae@quicinc.com>
Date:   Wed, 25 May 2022 11:58:49 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [RFC v2 32/96] cl8k: add fw.h
Content-Language: en-US
To:     <viktor.barna@celeno.com>, <linux-wireless@vger.kernel.org>
CC:     Kalle Valo <kvalo@codeaurora.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Aviad Brikman <aviad.brikman@celeno.com>,
        Eliav Farber <eliav.farber@gmail.com>,
        "Maksym Kokhan" <maksym.kokhan@celeno.com>,
        Oleksandr Savchenko <oleksandr.savchenko@celeno.com>,
        Shay Bar <shay.bar@celeno.com>
References: <20220524113502.1094459-1-viktor.barna@celeno.com>
 <20220524113502.1094459-33-viktor.barna@celeno.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20220524113502.1094459-33-viktor.barna@celeno.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/24/2022 4:33 AM, viktor.barna@celeno.com wrote:
[snip]

> +/* Message structure. */
> +struct cl_fw_msg {
> +	__le16 msg_id;  /* Message ID. */
> +	u8 dst_kern_id; /* Destination kernel ID. */
> +	u8 dst_task_id; /* Destination task ID. */
> +	u8 src_kern_id; /* Source kernel ID. */
> +	u8 src_task_id; /* Source task ID. */
> +	__le16 param_len;  /* Parameter embedded struct length. */
> +	__le32 param[1];   /* Parameter embedded struct - must be word-aligned. */

use of [1] is deprecated and this usage will potentially break with 
upcoming "fortify source" kernel changes

see 
<https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays>

when you change to use just [] make sure that any code that uses 
sizeof(the current struct) is modified to account for the removal of one 
__le32 from the struct