Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     =?iso-8859-2?Q?Ond=F8ej_Jirman?= <megi@xff.cz>
CC:     "tony0620emma@gmail.com" <tony0620emma@gmail.com>,
        "kvalo@kernel.org" <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Bernie Huang <phhuang@realtek.com>
Subject: RE: [PATCH 3/6] rtw88: Add update beacon flow for AP mode
Thread-Topic: [PATCH 3/6] rtw88: Add update beacon flow for AP mode
Thread-Index: AQHYSmYzKfcDpBas3E6lf9szC4Rq2K0v+8qAgACXDOA=
Date:   Thu, 26 May 2022 00:03:52 +0000
Message-ID: <e10c2c9b0c15479594703f2d03b0fa03@realtek.com>
References: <20220407095858.46807-1-pkshih@realtek.com>
 <20220407095858.46807-4-pkshih@realtek.com>
 <20220525230121.zk6xdjycxdhe62nw@core>
In-Reply-To: <20220525230121.zk6xdjycxdhe62nw@core>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering
 rules found
x-kse-antivirus-interceptor-info: scan successful
x-kse-antivirus-info: =?iso-8859-2?Q?Clean,_bases:_2022/5/25_=3F=3F_10:00:00?=
x-kse-bulkmessagesfiltering-scan-result: protection disabled
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-KSE-ServerInfo: RTEXH36504.realtek.com.tw, 9
X-KSE-Attachment-Filter-Triggered-Rules: Clean
X-KSE-Attachment-Filter-Triggered-Filters: Clean
X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


> -----Original Message-----
> From: Ond?ej Jirman <megi@xff.cz>
> Sent: Thursday, May 26, 2022 7:01 AM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: tony0620emma@gmail.com; kvalo@kernel.org; linux-wireless@vger.kernel.org; Bernie Huang
> <phhuang@realtek.com>
> Subject: Re: [PATCH 3/6] rtw88: Add update beacon flow for AP mode
> 
> Hello Ping-Ke,
> 
> please see bugreport below:
> 
> >
> > +static int rtw_ops_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
> > +			   bool set)
> > +{
> > +	struct rtw_dev *rtwdev = hw->priv;
> > +
> > +	mutex_lock(&rtwdev->mutex);
> > +	rtw_fw_download_rsvd_page(rtwdev);
> > +	mutex_unlock(&rtwdev->mutex);
> 
> set_tim is supposed to be atomic. See:
> https://elixir.bootlin.com/linux/latest/source/include/net/mac80211.h#L3500
> 

Thanks for pointing out.
We will fix it.

Ping-Ke