Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <32d207736ce219051d5cf3d1a17e829bfb3d34ff.camel@sipsolutions.net>
Subject: Re: [RFC v2 04/96] cl8k: add Makefile
From:   Johannes Berg <johannes@sipsolutions.net>
To:     viktor.barna@celeno.com, linux-wireless@vger.kernel.org
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Aviad Brikman <aviad.brikman@celeno.com>,
        Eliav Farber <eliav.farber@gmail.com>,
        Maksym Kokhan <maksym.kokhan@celeno.com>,
        Oleksandr Savchenko <oleksandr.savchenko@celeno.com>,
        Shay Bar <shay.bar@celeno.com>
Date:   Thu, 26 May 2022 20:24:04 +0200
In-Reply-To: <20220524113502.1094459-5-viktor.barna@celeno.com>
References: <20220524113502.1094459-1-viktor.barna@celeno.com>
         <20220524113502.1094459-5-viktor.barna@celeno.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-05-24 at 14:33 +0300, viktor.barna@celeno.com wrote:
>=20
> +ccflags-y +=3D -I$(src) -I$(srctree)/net/wireless -I$(srctree)/net/mac80=
211/
> +ccflags-y +=3D -I$(src) -Werror

Neither of these should be here. *Maybe* -I$(src), but that's probably
not even needed.

> +
> +define cc_ver_cmp
> +$(shell [ "$$($(CC) -dumpversion | cut -d. -f1)" -$(1) "$(2)" ] && echo =
"true" || echo "false")
> +endef
> +
> +ifeq ($(call cc_ver_cmp,ge,8),true)
> +ccflags-y +=3D -Wno-error=3Dstringop-truncation
> +ccflags-y +=3D -Wno-error=3Dformat-truncation
> +endif
> +
> +# Stop these C90 warnings. We use C99.
> +ccflags-y +=3D -Wno-declaration-after-statement -g

No no, all of that needs to go, don't make up your own stuff here.

johannes