Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2405780ioo; Sat, 28 May 2022 12:36:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxihTzrGfm7LOtXMWso1qbGMJMQGuB9AASuZkvpU024GqA9AjCdx0sZsCj0qpsATsQSCoHN X-Received: by 2002:a17:902:e74d:b0:163:783a:3473 with SMTP id p13-20020a170902e74d00b00163783a3473mr14283697plf.17.1653766568666; Sat, 28 May 2022 12:36:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653766568; cv=none; d=google.com; s=arc-20160816; b=0hVjgrSjOOP0flnFt2CHPYFgUAfOHRh8Lnvj2k3AOx/UV1UjKVDzXeEVgO+NULK/OF yaspuQI+N2DVPmk1Jv9S22rlJEvIYQp4vuePz7GoayGEntvqtdljenox14SZdNbtEKY0 96fZrk+JRx8b+WuJdePKa1q1Q2DdhTC5+N7XYhp7r3S4ZDyhLMfXEmw7ba8haNvF6Ppv YjLMzQbHw80NeyaWgy6QvT6SO8rLgxMdttTQsaXXbxaPrfgVGq/V9OTV4F2KJdyS+Jut uN4FTGcPA41WFhf1G1UftQHJSdC2mDr4zpT+6gsDjtRjzYtzKJ8gE7YeOgGjHnNCLX0W UptQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=Zr1YzpcWAUa93962UB1lWecxIfaq0zF46tLI2qTlHWo=; b=AJvZs4a5eLjeXCpWXn1wTHix6+t+oF7bpQDpI8ekForO9d0XfZEM7r1rhUfsj1XEuG cnnQINGXE0mSJ2jhHhYpCVIKTirxtz2Y36ME6AbMhPlutNyPOcA4PJJR95gUYLNqBsTm UsVDPsXS+058rTPpuSNrKAb5zQbf7YsQcYsMpJw399VS3Uy+5xgM3OzZpN7u9APVq2Pw Wp8SpVDAtnGiLgyrqjPJNzFXammpSKRm8rpDrLMNzcYtMPtqkAv80H+6LeEJKtPLVWpJ y2TmVDPbsDg9Ov4N/VOqnKCr8Ej9ldwR3IFVah4tgP6aZFxp4vBbwNt4u/IRRyXe11I+ nM4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dEn55Vpm; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id l13-20020a056a00140d00b0050dd2797010si11019746pfu.321.2022.05.28.12.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 12:36:08 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dEn55Vpm; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0D7AC387AC; Sat, 28 May 2022 12:01:46 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242436AbiE0GJc (ORCPT + 67 others); Fri, 27 May 2022 02:09:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231739AbiE0GJ2 (ORCPT ); Fri, 27 May 2022 02:09:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B8B4EC30F for ; Thu, 26 May 2022 23:09:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3516560E86 for ; Fri, 27 May 2022 06:09:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A7F7C385A9; Fri, 27 May 2022 06:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653631765; bh=e2bx8g1ZSPXC8wVCgZd27mdDgVxjXuh4ERx10fHKwto=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dEn55Vpme8voFhxOcXrvIz5WpS9pBITqTeBWK7Fd36L6v0xruj1c48cW73FvNh0fM 0+Vi2GCkQ+EvqARVhDLiGexXkK5yxfcT1LCFvQskH20UN2uQdpIQZw/TTCNaLn5GoQ D/GiIA9faPcDx6qRXepCqp/VQKbuW77F5jCdp2XzIey0iyvIFflWmiV/pcbNXKJZYB vQtzdNsLBPgFVWBJaHw0YQP+GSeAB0sL4ZDKzV4xaAdpcvGrTLNKSHO8Y88b2CBFDO lORwO+NXWCJDmSuC6SaWhhi6clt4unX8P8z1w08BfzYqHg655uZVbnS/iSrEa1jeJG RzkUG+kke5jJw== From: Kalle Valo To: Johannes Berg Cc: viktor.barna@celeno.com, linux-wireless@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Aviad Brikman , Eliav Farber , Maksym Kokhan , Oleksandr Savchenko , Shay Bar Subject: Re: [RFC v2 03/96] cl8k: add Kconfig References: <20220524113502.1094459-1-viktor.barna@celeno.com> <20220524113502.1094459-4-viktor.barna@celeno.com> Date: Fri, 27 May 2022 09:09:19 +0300 In-Reply-To: (Johannes Berg's message of "Thu, 26 May 2022 20:18:35 +0200") Message-ID: <87a6b3wlps.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > On Tue, 2022-05-24 at 14:33 +0300, viktor.barna@celeno.com wrote: >> + >> +config CL8K_VERSION >> + string "Version" >> + depends on CL8K >> + default "8.1.x" >> + help >> + Sets module version, which may be important for FW compatibility >> + analysis and syncing upstream codebase with the internal codebase. >> > > This, along with the def.h stuff using it, and MODULE_VERSION(), is all > rather pointless, I think you should remove it. s/should/need to/ :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches