Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp3554125ioo; Mon, 30 May 2022 04:54:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytq0miQlr7e/1F7vA65SrVUfGp4VizVaePiuNz9zLCp0fdYdPbgqcSO+gmZkPy+lYTdpDv X-Received: by 2002:a63:c0e:0:b0:3fa:c48f:d70 with SMTP id b14-20020a630c0e000000b003fac48f0d70mr25014037pgl.194.1653911646652; Mon, 30 May 2022 04:54:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653911646; cv=none; d=google.com; s=arc-20160816; b=cb29rEUZAOkFkMU2z6y3mginFeUJiCDawTNxNlhLahDiEzWPHE9syKWEdNBm12kyML Qc991x5LMj96Sg5JvV8FGRv7PhgC34o12mlk+C3Iylqww8KzyNbYPwoPPkSm4Z1CJqNL 6/SHU1ONX93saohyQPe4w76i16DNgqIqDEDt5G8HCqUYW37emAxQ4dOqXv5brQgTaFPK u0hR+CSLp2Sv582O99HElyE3OsTFcHj96C9ZEX2rNGrsya4BxMtesq4V4xX4VUhZ37Yg jKZMzDeQEBZdHIaX02e6SFOInVyJxjh4Ex/gvLyP/KV31Dg/DoIp3prOXT6t4yMUZ9qq 5LKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=3GDDugPNuhIQ0Ah4VYft5lgy1ka2aV6aAc8f5q+w26Q=; b=TCHvm94A80bgzDmNXEq8BU2sSUnbLvvfvCZ8XTTbKkNSX3b4n3VtlxoMVI/+jij74a iUrGVlI8mqEMhovN+C/T0FhgHZtgacknBRU6Jk5Bar2FeXjpmM//TWfn9V9uJ5zpEa6C Ohxa8tI6CvHNUNMM52jatjEAos7/hYAvhh16XQ2O633Ndi9AYmG9dDnOmX7umbVZD7NB WWGm3X563xUd7mn8Bf+q6MnqBCMX/R73xOC4L/Z7WY3XQ6Mj8Wj+V3ztIx/709ishsgV ZalsE1REUoIcQBNPm8vHPNq2NYpEPHjja4xcRMdCAusqTa/ZZjnhzUmA13oS3r7TY9Nz 4W/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WAegGU6I; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020aa79809000000b0051840478994si14063757pfl.375.2022.05.30.04.53.56; Mon, 30 May 2022 04:54:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WAegGU6I; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235538AbiE3LGs (ORCPT + 67 others); Mon, 30 May 2022 07:06:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235585AbiE3LGq (ORCPT ); Mon, 30 May 2022 07:06:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40A88D117 for ; Mon, 30 May 2022 04:06:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F268EB80B8F for ; Mon, 30 May 2022 11:06:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95FC6C385B8; Mon, 30 May 2022 11:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653908800; bh=PIMknSel6vdlDHo8m2N5toFmbS7GgtpqhCzipArqsW4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=WAegGU6IHUB+Xy4hG5kW4uz9/rDV8Qi1DFRiw5/Rqx0d/0GPtbEeb+/0jD//cvrHd kxP8+yokCf9MNIOkRynQ6IlnlNoP8+vHjKir4accQdKbxc3CRaNZCH+G+sLZ2N+kaH 2Uppoj4RoTxtUNECqT1aMbN0FN0FHRVyq38HZMMstvtPErSqM8CGX0ZHAEeuxMPMrC MaaGlRmCtVriBMX8AnWPOGXTCoOcKGes9V99+VsOgMT1woEbQd/+sUYDmVvpuUIlhS /5gb99gLk9urDAd5fg/OHAvSLexk9O2c+2QFRV7HEH2+N9duSYJlESBD2wIqaMpJi2 ixH/vcO4lW7Sw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v3,1/4] wifi: rtw88: Fix sparse warning for rtw8822b_hw_spec From: Kalle Valo In-Reply-To: <20220524153621.19027-2-Larry.Finger@lwfinger.net> References: <20220524153621.19027-2-Larry.Finger@lwfinger.net> To: Larry Finger Cc: Johannes Berg , linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <165390879742.29197.9087460498259219353.kvalo@kernel.org> Date: Mon, 30 May 2022 11:06:39 +0000 (UTC) X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Larry Finger wrote: > Sparse lists the following for rtw88: > > CHECK drivers/net/wireless/realtek/rtw88/rtw8822b.c > drivers/net/wireless/realtek/rtw88/rtw8822b.c:2500:22: warning: symbol 'rtw8822b_hw_spec' was not declared. Should it be static? > > The warning arises because the external declaration for rtw8822b_hw_spec > occurs in rtw8822be.h, which is not included in rtw8822b.h. That line is > moved, and the now empty file rtw8822be.h is deleted. > > Symbol 'rtw8822b_hw_spec' can be made constant. > > Signed-off-by: Larry Finger > Cc: Ping-Ke Shih 4 patches applied to wireless-next.git, thanks. f429298d68fb wifi: rtw88: Fix sparse warning for rtw8822b_hw_spec f86fc57f8ae3 wifi: rtw88: Fix Sparse warning for rtw8822c_hw_spec e36db29cfdff wifi: rtw88: Fix Sparse warning for rtw8723d_hw_spec 89d8f53ff6e7 wifi: rtw88: Fix Sparse warning for rtw8821c_hw_spec -- https://patchwork.kernel.org/project/linux-wireless/patch/20220524153621.19027-2-Larry.Finger@lwfinger.net/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches