Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Maxime Bizon <mbizon@freebox.fr>
Cc:     Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
        ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
        devicetree@vger.kernel.org, robh@kernel.org, mka@chromium.org
Subject: Re: [PATCH v7 4/9] ath11k: Add register access logic for WCN6750
References: <20220429170502.20080-1-quic_mpubbise@quicinc.com>
        <20220429170502.20080-5-quic_mpubbise@quicinc.com>
        <bd6d97a4cc6665d0ee632444f75e3480160387ec.camel@freebox.fr>
        <c57e8791-b6ce-0752-52ca-a1cb938187d7@quicinc.com>
        <c1c3472427080716c69ad99ebe5d1954db44f03f.camel@freebox.fr>
Date:   Mon, 30 May 2022 19:17:29 +0300
In-Reply-To: <c1c3472427080716c69ad99ebe5d1954db44f03f.camel@freebox.fr>
        (Maxime Bizon's message of "Mon, 30 May 2022 16:19:06 +0200")
Message-ID: <871qwbouzq.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Maxime Bizon <mbizon@freebox.fr> writes:

> On Thu, 2022-05-26 at 09:12 +0530, Manikanta Pubbisetty wrote:
>
>> 
>> Thanks for letting me know about this, IIRC I don't remember 
>> encountering this problem in my testing. Just for my understanding,
>> have you reverted this change and confirmed that these errors go away
>> ?
>
> I first confirmed the register location was indeed incorrect, then I
> fixed it like this:

Looks good to me. Can you submit that as a proper patch?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches