Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp4420874ioo; Tue, 31 May 2022 04:13:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbEdHgCYKZ3H4swtDRIteTbiYncgMK8FSbvaN/0g9bEMnOQgQYh0am+A5ZZuymp/os81QS X-Received: by 2002:a05:6a02:19b:b0:3fa:3e63:15fb with SMTP id bj27-20020a056a02019b00b003fa3e6315fbmr38321393pgb.129.1653995634975; Tue, 31 May 2022 04:13:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653995634; cv=none; d=google.com; s=arc-20160816; b=u56HQjT6ZCh493kI6voHbwtC06395FvWJObzflV8U0qY/xrvtbcdOEScup4TqoDSvF m9MM6wHhhOsdK/zIGSaDT/8a3wquq6Onnq3kl9lJidMCYrQ73Ynsdv58MfQfZdcvUQUH Ot0oP5xG2eRZ0Jue54wyX1tTgYBcWPu04FEz7ZDQMde4+eY+OA0FhrRCTpVq7Lr54wZP aZJvcMVBezasBn/gnMRYxRJhg/VX9hKNWcrReS9vMDL/8jvOZfcoi5iS2C5E5QejPTsZ OEP5W6DtlMnyvW+ILgz71c41kibcI7B3lYfnVRVscDafPUAjnnZdSDB+PFYhuGWAme9C oVQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=QBOSZN5Bo0WGihVnLzJVnszMoIBWOFsUU8p28txRYE0=; b=hvtCDk+VIZytmO6rNahpW+E6D19ibzbqQXFAFNUvdOIRHtN4HvZmm5ioWKZIMCdV4y VShJl/lAoqvpBMf0LyUUOK08GLvvtZAzcRLdIKhKHHUL7rfnqWLFJTznk7pIC0Kiifyz 2CmGmjg5QTEC4liatFhhaea3Luac8Cx5FNPD7f8P8tjFgJPZQqhEiUKriYuhkBKq/Oz0 g1OXVQsjSCFc1/Ga2VY8YSP0mF7BwnPozRedfmXlQa5Cmbnc3vAm9284GwRRTnilbwjc jKzNeZeNX7+oFW++NH/OL+7QYXnAVnQ4NMRD1j4J7XLetNWKH2811gA2MFrt+GsL4EP/ sR6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n1-20020a17090a9f0100b001e0cf692b8dsi2491104pjp.80.2022.05.31.04.13.42; Tue, 31 May 2022 04:13:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244595AbiEaHm6 (ORCPT + 67 others); Tue, 31 May 2022 03:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244578AbiEaHm5 (ORCPT ); Tue, 31 May 2022 03:42:57 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D142A4990F for ; Tue, 31 May 2022 00:42:54 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nvwWb-0004H2-UK; Tue, 31 May 2022 09:42:45 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nvwWa-0008IW-1P; Tue, 31 May 2022 09:42:44 +0200 Date: Tue, 31 May 2022 09:42:44 +0200 From: "s.hauer@pengutronix.de" To: Ping-Ke Shih Cc: "linux-wireless@vger.kernel.org" , "johannes@sipsolutions.net" , "kernel@pengutronix.de" , "neojou@gmail.com" , "kvalo@kernel.org" , "tony0620emma@gmail.com" , "linux-kernel@vger.kernel.org" , "martin.blumenstingl@googlemail.com" , "linux@ulli-kroll.de" , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 10/10] rtw88: disable powersave modes for USB devices Message-ID: <20220531074244.GN1615@pengutronix.de> References: <20220530135457.1104091-1-s.hauer@pengutronix.de> <20220530135457.1104091-11-s.hauer@pengutronix.de> <1493412d473614dfafd4c03832e71f86831fa43b.camel@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493412d473614dfafd4c03832e71f86831fa43b.camel@realtek.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, May 31, 2022 at 01:07:36AM +0000, Ping-Ke Shih wrote: > On Mon, 2022-05-30 at 15:54 +0200, Sascha Hauer wrote: > > The powersave modes do not work with USB devices (tested with a > > RTW8822CU) properly. With powersave modes enabled the driver issues > > messages like: > > > > rtw_8822cu 1-1:1.2: firmware failed to leave lps state > > rtw_8822cu 1-1:1.2: timed out to flush queue 3 > > Could you try module parameter rtw_disable_lps_deep_mode=1 to see > if it can work? No, this module parameter doesn't seem to make any difference. # cat /sys/module/rtw88_core/parameters/disable_lps_deep Y Still "firmware failed to leave lps state" and poor performance. Any other ideas what may go wrong here? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |