Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp5503751ioo; Wed, 1 Jun 2022 06:58:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLJ+pyQj/lo+eoJvygUFeF4SNBE7wdVM8ViitCeXAECqtQJ8f49YFSiZeqBBvXU2SJjJtJ X-Received: by 2002:a63:2109:0:b0:3fc:9fdf:f4e0 with SMTP id h9-20020a632109000000b003fc9fdff4e0mr94822pgh.586.1654091910538; Wed, 01 Jun 2022 06:58:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654091910; cv=none; d=google.com; s=arc-20160816; b=w9R7mxim9Z4uZ4O+T8QTw3LvoHjHMm0Tp3pMO7vtaGkFMuAlTMp+rOizxaKxN+yWw4 mZDEeK8XZsrMcyRw8aDdhuNtzc03EoqVOToh+ddvyh8k0hY3pdGTkxE6Dp0cmxabN8aR 7cOEqfArF1xwZuOTjLieQqMXob0xkOplyUEn42XN3+nB+Uq+/EVjf0ucgKDs3s6tOge+ 27XaDEsQBmIJtpCySjwiLpHfB6ZdBICpgQeOEBMspSQPt2ORcUoekC1PLxW/h0K16v6q 3SVJvJdzuE2neBx7saeb1vEVS7jKslZ1KxoUFahjfRrrOdUvfIt84+1qve/lgtNupURS YnyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:dkim-signature; bh=qSoHSisJW/tjHmDP8Gn/as1BUYYT4FxKuAOgefP6kz4=; b=M8HnORXPXsGRyFv6IuKrg7ZSNOln4NvcTMSYkaK37YVXv13jmtWXk+xEXoKd6fHa41 CRQbNzIPDG+sanxSoMizjUQhWBSWOJ+/9MQx2AGMZxayiHnevMLEsZ3lve3JNadhsB+V x+yQRscZsFaEqfnCVg1dOa8Rk3Gj2eY0Mkdvw41GTdB3u2kMAq0mdBHwl+YMCZEUO474 yIxKH1lfyEOU8eB7ryV7eP+N44Q2cQjGswGtFop4T5VcVCysf5loMMbckbIhzk/wN1tL ZrRLMTIxjFGNsjRmDuSPEVhofokRoCtDIOTA80T6PaoItWr7F30P/yTXLvPCuDnV19Pp M8BA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ieofgAta; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 186-20020a6300c3000000b003fca8e98747si1943851pga.622.2022.06.01.06.58.21; Wed, 01 Jun 2022 06:58:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ieofgAta; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349761AbiFAGTK (ORCPT + 67 others); Wed, 1 Jun 2022 02:19:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349769AbiFAGTF (ORCPT ); Wed, 1 Jun 2022 02:19:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 870BF6A066 for ; Tue, 31 May 2022 23:19:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D0A9DB817F3 for ; Wed, 1 Jun 2022 06:19:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BC04C385B8; Wed, 1 Jun 2022 06:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654064341; bh=ahMPCuEzja98C3+MLmZ8Jd2FzggqehBUIJvPVQ7VFrY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ieofgAtaeXVEwHv6/xMMfC6LsZGlRXwgU0WGN63NxOW68KVRKcw4oginLBIbr5qH4 m7vVoN9aTHIHG9EbdYuohnVVGVATwWnvCN/eMQCb1bEjoFLGHFx2eqvKjlWiDeYEh6 yLUWs4PDlORmjhqDWyLOQLSjBEL6a43PiE1N3m3lJGaPz1DfEM6j/E4/mmY9R04I1t eHMxJI1toIpkbpc22UbZWqDTcc5rTP0q7L1yd1pPkoeub9dzYXH4mKMiDnrzvoJ+on O7+F2Fulig1h2+l2JQqyoyHNTaD5QQQpt8RXM9m8slxSoYUi89TtP5BviEILphwfiM wfteuSsgHI6Qw== From: Kalle Valo To: Jeff Johnson Cc: Christian 'Ansuel' Marangi , , Subject: Re: [PATCH 2/2] ath11k: fix missing skb drop on htc_tx_completion error In-Reply-To: (Jeff Johnson's message of "Tue, 31 May 2022 13:32:18 -0700") References: <20220528142516.20819-1-ansuelsmth@gmail.com> <20220528142516.20819-2-ansuelsmth@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Wed, 01 Jun 2022 09:18:57 +0300 Message-ID: <87v8tkoqi6.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jeff Johnson writes: > On 5/28/2022 7:25 AM, Christian 'Ansuel' Marangi wrote: >> On htc_tx_completion error the skb is not dropped. This is wrong since >> the completion_handler logic expect the skb to be consumed anyway even >> when an error is triggerer. Not freeing the skb on error is a memory > > nit: s/triggerer/triggered/ > > Kalle can fix this when he merges so no need to post a correction Yup, fixed now in the pending branch. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches