Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp5868583ioo; Wed, 1 Jun 2022 14:30:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvh43Y8B0sc2wq+43F08Lym3d8LPNhnd/lQLTkO1iS0F8naE69p5DqDCtCLBRp4DHs78hx X-Received: by 2002:a63:84c3:0:b0:3fc:87ff:cdfa with SMTP id k186-20020a6384c3000000b003fc87ffcdfamr1168596pgd.460.1654119053739; Wed, 01 Jun 2022 14:30:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654119053; cv=none; d=google.com; s=arc-20160816; b=adb0OcSrgo4nXz+V6Rg569xsOA8nSu98d7xcXadmxE52RHmRVKnzVBBDGRjOq1rxE1 c2+DPtJW7G1/oGJ3durmDejjAFWgzcaKuiH5Hyfp7CnOe+LcY/vz46ns4pK6l4UOw2Ya 6WnY4BQX3YP1/VJdPTCDpcrhChbkmfuCV83S2VHZq1eikptKUlWV5EimyKsDZ7PsX4mX DqPLYUFYFofwqs5wI6PzHd5d2rIrjKA8L2rn9+O0HUfcCRUeEhms+Yor0pCXO7v3uBxp ptf2jRTCc2ocO416eAGArunSoldmcn5aHoqvuk06X+kMyqJafJv6TLCAdL5VVwxI/J9x Szqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:dkim-signature; bh=JAVDRJSSdtTN6NFBbruaw741kxUI3kUtROUWIudDn/E=; b=awWlUuxL7TV9gv8NfRnyunH41tflYzOWQICh5O9Dtk+ZGelrB3pVCcrfRXsJKzZhXX 7VCVYQnKfOz2fYPcKwoGpOkNvdmF1PT0lDVRpasK4Hoj0cbjGGxTjL9Y+m6CnyzJSjtd EfZuCnl1Ltv9o0jyLBJ1eoWj9xVLBrgAPXAM3f4mGIGh6Jpfr8gOld7JGYWBmbAlPXoq AKwYW0go0fLb7uDziLAfUINW5ZrzQXoo3Jxdt7JsgXpiOI6QlF1C1jlik9bJbMBRacGy VCdE51oBIyuiSJcEymRnECIuvocwo+avJPHqUgTExNZpkeIs0MQQ+/WDCSTllF+Tez7H GlMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=tdzfxUNg; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id k7-20020a170902760700b00158e5bfcc7dsi3815989pll.136.2022.06.01.14.30.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 14:30:53 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=tdzfxUNg; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 669E32A7A88; Wed, 1 Jun 2022 13:22:01 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229594AbiFATni (ORCPT + 67 others); Wed, 1 Jun 2022 15:43:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbiFATnh (ORCPT ); Wed, 1 Jun 2022 15:43:37 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E773F1C7EE2 for ; Wed, 1 Jun 2022 12:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=JAVDRJSSdtTN6NFBbruaw741kxUI3kUtROUWIudDn/E=; t=1654112508; x=1655322108; b=tdzfxUNgs9u/xX9UJ6GiUS1Ej5pIF8/T3n16yJCIboaanLK KU9xuKxMXwR+CXfajXdOVubyFs5k0JoVAfSEBOR89PsoJLRhi7ehG+PRKlL1+XGVS99sw1TktbkK1 lGGV/PjxClf0Gt3j2VO2oJIPXQs3q97ZimP2oh5KdP2lJLWV5RJEvSAGsNjNRQeTl20athjw5L9z0 a+3kUgAMXjMCv3FDj/6HIDGCPoOMg/14KXCm+GeaiRzOIOyqJv/0UsBCEL+adQuKAq77oOVBpXfti aRQmPasyao0dV/2jNFl/NtF3t4i15TPqoKXhZWeeK6P5xKIJWALQfWPtkuTHhmXg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1nwUC1-00AX0p-WE; Wed, 01 Jun 2022 21:39:46 +0200 Message-ID: <5f5502b05106dea7fae829c22a8e4fad0a1f6da5.camel@sipsolutions.net> Subject: Re: [PATCH 01/15] mac80211: split bss_info_changed method From: Johannes Berg To: Jeff Johnson , linux-wireless@vger.kernel.org Date: Wed, 01 Jun 2022 21:39:45 +0200 In-Reply-To: <4a74852a-0a19-7fe5-95e6-09317bfe0eb3@quicinc.com> References: <20220601073958.8345-1-johannes@sipsolutions.net> <20220601093922.347d47c279fe.I15937cfe8405999084f164ddf57390f8b8d2bc61@changeid> <4a74852a-0a19-7fe5-95e6-09317bfe0eb3@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2022-06-01 at 12:31 -0700, Jeff Johnson wrote: > On 6/1/2022 12:39 AM, Johannes Berg wrote: > > From: Johannes Berg > >=20 > > Split the bss_info_changed method to vif_cfg_changed and > > link_info_changed, with the latter getting a link ID. > > Also change the 'changed' parameter to u64 already, we > > know we need that. >=20 > [snip] >=20 > > - wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss info changed vif %p changed 0x%= 08x\n", > > - vif, changed); > > + wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss info changed vif %p changed 0x%= llx\n", > > + vif, (unsigned long long)changed); >=20 > just curious about the typecasting. >=20 > https://www.kernel.org/doc/html/latest/core-api/printk-formats.html=20 > indicates we should always be able to use %lld or %llx for u64 hence no= =20 > typecasting should be needed >=20 Hm. I think you're probably right - I used powerpc 20 years ago and it had 'unsigned long' for u64, but I guess that changed a LONG time ago... Yep, commit fe333321e2a71 (Jan 2009). Sorry, old habits die hard. :( johannes