Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp6761092ioo; Thu, 2 Jun 2022 13:09:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWf0ssEor9aqQyIgpheQcxUyyRitd5mQ/APt/CYxUcvfkaFT9MJkYUdFhq7mZ+IH3C+9O8 X-Received: by 2002:a17:907:3e18:b0:6fe:cf44:8692 with SMTP id hp24-20020a1709073e1800b006fecf448692mr5747388ejc.601.1654200553488; Thu, 02 Jun 2022 13:09:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654200553; cv=none; d=google.com; s=arc-20160816; b=kdP7G3tO9Ns8jsPRfdl8ye4zyKahi3GWR/6JT6eIeD/kQDj+vRj1kkFadg76KFx6ip 5Jwst1SoyYqkbsFlcsmrfQf7hHTbXno3Xzub23NsDZTzUxEV8Vxjqc/GjONg53z1uGPK vA3PYIf9nsH96MlyWhmxeqxH2d/HROV7BhVpfQBSyr7BW1rbx8Ye7zLt6F7qnRpYZ7O4 Onzrnuoozm0iGA9Fa09O8fNT5PdsAHEV2EGsSGh7mpxPkjD1HqXISf2cTdwU6Wu3AFLD Cv0anTkJU4iKqh8FwBKUEfMqzJY+jsz+R5QMmg2kwCQRzo6RL01KGheXRKagQQBni0aw Vz0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=Zd4F+BvxvpoWw0E7dWqQSZOT7syxj2Njz3KGiWilgu8=; b=eYer5KnIquTxV9BPDGlm9IdV8Pywcdt6NTeLVsElGjSz6HyGgxulmYLloFaXvGmQIx RJPPhhjQS86jB8FHwu8L6SsCSO/UoqKkqrN1PIl1KjlILws6LmvCPmYkgjIv3hf8ta/8 3LcJ8IK5s7JdNscxMTLSnhSMsKrkxWraDnYwBFW7yFplSL4rfoQtLkmC1JGSkZRlkeKQ AmLldzERT9DsVQYIj1e8n0HaeurDW2DnvekOqGtMJr79oC0KNT5+KLzStZuJ1T/cKIc/ 7viilZ6YDyZRqQtmcRbKfXs8v5JMV25fJR/fJzgZq66oT4znDDMZDXwZzuunmQs2mlFn e39g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=EWlO84wx; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x13-20020a05640226cd00b004264948a110si725773edd.615.2022.06.02.13.08.55; Thu, 02 Jun 2022 13:09:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=EWlO84wx; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238919AbiFBTwS (ORCPT + 67 others); Thu, 2 Jun 2022 15:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238037AbiFBTwN (ORCPT ); Thu, 2 Jun 2022 15:52:13 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A1051FA66 for ; Thu, 2 Jun 2022 12:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject :To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Zd4F+BvxvpoWw0E7dWqQSZOT7syxj2Njz3KGiWilgu8=; b=EWlO84wxv6wNDR+5xixkhoU0a9 9CbUl6aML+ZxGKBIbVAdJnNQQM7XjNISQuV/nJrxJKgSSQS87emullYTI3I6rrGezJryCcs8bP/n0 6e9sQDLZB78zEg9J/ZKZPZx9tesq1g/PBysBHA/hj7QpHCgPIkXpPgbz2feOYGHRg4YY=; Received: from p200300daa70ef200058bb5d56adcce0c.dip0.t-ipconnect.de ([2003:da:a70e:f200:58b:b5d5:6adc:ce0c] helo=localhost.localdomain) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nwqrY-0004yp-AJ for linux-wireless@vger.kernel.org; Thu, 02 Jun 2022 21:52:08 +0200 From: Felix Fietkau To: linux-wireless@vger.kernel.org Subject: [PATCH 1/2] mt76: mt7915: add missing bh-disable around tx napi enable/schedule Date: Thu, 2 Jun 2022 21:52:05 +0200 Message-Id: <20220602195206.31061-1-nbd@nbd.name> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org napi_schedule() can call __raise_softirq_irqoff(), which can perform softirq handling, so it must not be called in a pure process context with BH enabled. Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c index 27b3080469a1..00d670fa26c9 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c @@ -2183,8 +2183,10 @@ void mt7915_mac_reset_work(struct work_struct *work) mt76_worker_enable(&dev->mt76.tx_worker); + local_bh_disable(); napi_enable(&dev->mt76.tx_napi); napi_schedule(&dev->mt76.tx_napi); + local_bh_enable(); ieee80211_wake_queues(mt76_hw(dev)); if (ext_phy) -- 2.36.1