Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp6945623ioo; Thu, 2 Jun 2022 17:54:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPcHgP7jmPSxWC0hRKn/NKWjYiFWjTmvzRW4YnTksZyptlYPP6vTxSoOjarpA9GoqRf9nM X-Received: by 2002:a17:906:1c56:b0:70e:ad6d:5e87 with SMTP id l22-20020a1709061c5600b0070ead6d5e87mr215922ejg.491.1654217677053; Thu, 02 Jun 2022 17:54:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654217677; cv=none; d=google.com; s=arc-20160816; b=V8UnCWEWt2MqbhJba9N8kW5ubosGNY80F3GMfqPwR8wENy7E2IiPz5CmKbS5552pXl El+/c6zQ3CcMl7x+1jdZ+uY87QDGpRyVRQGivhrQfZaaRzBW3zfCNbtTMUHFI48PgncW p7h0D/DD2wgq79+NWoQjk50etFhQMS25wlRW9glXcgDpVWB9+fGUPsQ5Ekt7wWtKkHHP ovMg0XM/M8WEAF3jOsAqtpew6akWfBL2ElzG7V2SzaT6BKt0IbQN3Z6y+lqDvDrZKJtz yHvx3xs2y0k02gFsrCy3LSQ5UQVsv+GrDi8JDDqaIKbMAN73Ez7xoZ98oQnUPSilTI/1 vdnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=wwg5Fn4ZR/f4m/a3Lub/EGiIHyASoRXB1ZgE5pTZGYw=; b=kwImUmrvGGw5T0Yzje7q4gvuIPi9GR5f82Otzv80PX/sHE2gG8PONcOhmVYtHDHiyO YTi1gCdTfI7eSyNXbJdhU9l1MbqVyBKxpuUGXn7xrlXEV79apSrI3eFSAq566bwaPibA pydAvkYFXIK4rd5lyha/zwWSJRTGSK9KSHPr/SzDEv9vkjH3g4o8TCqB89snii2kNumB ZVd7LKMAKUBw9qiYEeKtz9i7bUA7ISZCXqHNvr9dGr1cq4SY7T6v3ku3oZdcIzEK1rY/ x2n56FlrK8CvsaKmqrzJ6Af4uJO1VHjSmstLmkhBbVPtvCsqf32VBi+M3784ZkrovaQk qivQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=R1IxFxwK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dd4-20020a1709069b8400b006f3ce72ceb7si7314076ejc.531.2022.06.02.17.54.20; Thu, 02 Jun 2022 17:54:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=R1IxFxwK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238900AbiFBTwT (ORCPT + 67 others); Thu, 2 Jun 2022 15:52:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238383AbiFBTwN (ORCPT ); Thu, 2 Jun 2022 15:52:13 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A9A21FCD1 for ; Thu, 2 Jun 2022 12:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wwg5Fn4ZR/f4m/a3Lub/EGiIHyASoRXB1ZgE5pTZGYw=; b=R1IxFxwK9dgnoOC4yhkUdPZC3J 4SGRmb2/f3ibIN+76xZ4EVN5Uct/t3YhB7zmQLeDtKXEyz0/LxSvenYSbcPuPMIUSa/T7M3EUpJdw GMZFze0jociuTblOQKSsfA+GRQYeUz8k2kpkWimNAzIE1vJgJXEQhjQeL6t6HDYuBjYY=; Received: from p200300daa70ef200058bb5d56adcce0c.dip0.t-ipconnect.de ([2003:da:a70e:f200:58b:b5d5:6adc:ce0c] helo=localhost.localdomain) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nwqrY-0004yp-H9 for linux-wireless@vger.kernel.org; Thu, 02 Jun 2022 21:52:08 +0200 From: Felix Fietkau To: linux-wireless@vger.kernel.org Subject: [PATCH 2/2] mt76: mt7615: add missing bh-disable around rx napi schedule Date: Thu, 2 Jun 2022 21:52:06 +0200 Message-Id: <20220602195206.31061-2-nbd@nbd.name> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220602195206.31061-1-nbd@nbd.name> References: <20220602195206.31061-1-nbd@nbd.name> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org napi_schedule() can call __raise_softirq_irqoff(), which can perform softirq handling, so it must not be called in a pure process context with BH enabled. Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c index bd687f7de628..f26213c4e64c 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c @@ -2094,8 +2094,10 @@ void mt7615_pm_wake_work(struct work_struct *work) mt76_connac_pm_dequeue_skbs(mphy, &dev->pm); mt76_worker_schedule(&mdev->sdio.txrx_worker); } else { + local_bh_disable(); mt76_for_each_q_rx(mdev, i) napi_schedule(&mdev->napi[i]); + local_bh_enable(); mt76_connac_pm_dequeue_skbs(mphy, &dev->pm); mt76_queue_tx_cleanup(dev, mdev->q_mcu[MT_MCUQ_WM], false); -- 2.36.1