Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6fe32a06-a960-3a77-37fd-bc51af1b4c4f@quicinc.com>
Date:   Thu, 2 Jun 2022 13:59:38 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [RFC v2 76/96] cl8k: add stats.c
Content-Language: en-US
To:     <viktor.barna@celeno.com>, <linux-wireless@vger.kernel.org>
CC:     Kalle Valo <kvalo@codeaurora.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Aviad Brikman <aviad.brikman@celeno.com>,
        Eliav Farber <eliav.farber@gmail.com>,
        "Maksym Kokhan" <maksym.kokhan@celeno.com>,
        Oleksandr Savchenko <oleksandr.savchenko@celeno.com>,
        Shay Bar <shay.bar@celeno.com>
References: <20220524113502.1094459-1-viktor.barna@celeno.com>
 <20220524113502.1094459-77-viktor.barna@celeno.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20220524113502.1094459-77-viktor.barna@celeno.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/24/2022 4:34 AM, viktor.barna@celeno.com wrote:
[snip]

> +static void _cl_stats_update_tx(struct cl_hw *cl_hw, struct cl_sta *cl_sta,
> +				struct cl_agg_tx_report *agg_report)
> +{
> +	struct cl_stats *stats = cl_sta->stats;
> +	struct cl_tx_cntrs *cntrs;
> +	union cl_rate_ctrl_info rate_ctrl_info = {
> +		.word = le32_to_cpu(agg_report->rate_cntrl_info)};
> +	u8 bw, nss, mcs, gi, bf;
> +
> +	switch (rate_ctrl_info.field.format_mod) {
> +	case WRS_MODE_HE:
> +		nss = (rate_ctrl_info.field.mcs_index >> 4);
> +		mcs = (rate_ctrl_info.field.mcs_index & 0xF);
> +		gi = rate_ctrl_info.field.gi;
> +
> +		{

why an embedded block? seems to serve no purpose

> +			bw = rate_ctrl_info.field.bw;
> +			bf = agg_report->bf;
> +
> +				cntrs = &stats->tx.he[bw][nss][mcs][gi][bf];

bad indentation

> +		}
> +		break;
> +	case WRS_MODE_VHT:
> +		bw = rate_ctrl_info.field.bw;
> +		nss = (rate_ctrl_info.field.mcs_index >> 4);
> +		mcs = (rate_ctrl_info.field.mcs_index & 0xF);
> +		gi = rate_ctrl_info.field.gi;
> +		bf = agg_report->bf;
> +
> +			cntrs = &stats->tx.vht[bw][nss][mcs][gi][bf];

bad indentation

> +		break;
> +	case WRS_MODE_HT:
> +		bw = rate_ctrl_info.field.bw;
> +		nss = (rate_ctrl_info.field.mcs_index >> 3);
> +		mcs = (rate_ctrl_info.field.mcs_index & 0x7);
> +		gi = rate_ctrl_info.field.gi;
> +		cntrs = &stats->tx.ht[bw][nss][mcs][gi];
> +		break;
> +	case WRS_MODE_OFDM:
> +		mcs = rate_ctrl_info.field.mcs_index - RATE_CTRL_OFFSET_OFDM;
> +		cntrs = &stats->tx.ofdm[mcs];
> +		break;
> +	case WRS_MODE_CCK:
> +		mcs = rate_ctrl_info.field.mcs_index;
> +		cntrs = &stats->tx.cck[mcs];
> +		break;
> +	default:
> +		return;
> +	}