Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp7967268ioo; Fri, 3 Jun 2022 18:25:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzx88EaCaAkBwY8bJ0tOPAsmEXN71XiDlE+NwQPhNOu+/Hu2cEeglTwCNqtxWoy6dgCBkEQ X-Received: by 2002:a63:4d5d:0:b0:3fc:159c:8159 with SMTP id n29-20020a634d5d000000b003fc159c8159mr11133773pgl.106.1654305916782; Fri, 03 Jun 2022 18:25:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654305916; cv=none; d=google.com; s=arc-20160816; b=eAg/4SYG3cxeeCjkpQI70etN2M9S1Modw51UIA6lCgsACBUR4B9Vv0bxZxFv7+sE0Q vUNUQirV9A3qGiZqUGDdz8vNynVVIMgRq703KEiwSgKT4Fh2dHy7zuowNXjPPUHYPvAx V4eRiWj6OThJ7cHfeWSqijTvcuLrOviWn14AZsSKpbecAx7JbCMx+rFJUp4UsuLfvQ96 9BNae0DMNY2E81/5j6Z40K5PRovu8hwyoS4p8jaf5lZb6qnXeA8DHC5P9jrxoS+UOLeu QDhy7BHESXLRKseyOUlzUgvbXOvJOTSMLpazWtPXRvjVsRVodDu0ImWS7fAn+fMfELNM cZLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rFMNOPBfUMj59ggpQ7Vwolfmoe4IVjgR4MHduDtPN40=; b=x+ILby9ErxJcggJvKoqEhkoORYb56/CIvFwqlv26aM81vjqPsk6+hAiifKghzrOipu HY/ROlInXCtkIpJbYKz5TLqawDfJ6M9nbFiFyrM9V8MxW84ZMusBPshSFaqjKLTfQMq0 pbWQtcKeSP3hk0/C5G8WP4jJXPaDT+8EVUyM7TcIsNnJP0DtiyqLFN2c9IfW4HY3/loY BR0GKyQSmRWym2AMwHPPRSS9BTjW8COIkrqzBbNj86DYorP5WrRMenMm0BkyuQEAeh78 Fy9C3VqNJgLcn+XM3XTNeFeMkXgr0oynd3FuElbWlVgK0c5eIf/9rKBy4R7Idc7yNcDj qbCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oJwNILuT; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q2-20020a056a00088200b005190631b525si13459212pfj.148.2022.06.03.18.25.01; Fri, 03 Jun 2022 18:25:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oJwNILuT; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242514AbiFCHfZ (ORCPT + 67 others); Fri, 3 Jun 2022 03:35:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242620AbiFCHfP (ORCPT ); Fri, 3 Jun 2022 03:35:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A324338AB for ; Fri, 3 Jun 2022 00:35:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E4DE0618F3 for ; Fri, 3 Jun 2022 07:35:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78AFEC385A9; Fri, 3 Jun 2022 07:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654241713; bh=9RgZEj/aGukWMOOD7s+ViFEIX89kzK0VQUFSq29TzN4=; h=From:To:Cc:Subject:Date:From; b=oJwNILuTb9E5eh/dThPHVa7ATUct1Jr5mmWOkUKpHAEsslk6ttYgtC03kIrbJFbAE gHbcnn8yxletEK8gJNOmHrSZKX9vj+zICk2Z0HnV0CH1vTOTNC4+6lGY+EfghnPx/y ebyoe8zjg4xW/TKx0/R72MjGtnLMPINj0qq/dXd/LrelkYEdAAx/8tqcmLET1nL31L tPF1kSmww5EHkmMTE/5GlnwIVKZIq6uWaPUJ1MIjyuHadTAZtQRkAoDcJORSOeq4Zq 9V3EcfVYFdxnwFzLS1h6FiRayDjtjCeXy27dW5i60hRuhu7De0QrwDv8xJ4hGWMIrg YaVplggsr09aw== From: Lorenzo Bianconi To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com Subject: [PATCH] mt76: mt7921: add missing bh-disable around rx napi schedule Date: Fri, 3 Jun 2022 09:35:00 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org napi_schedule() can call __raise_softirq_irqoff(), which can perform softirq handling, so it must not be called in a pure process context with BH enabled. Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c index a630ddbf19e5..01ed779d3976 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c @@ -1538,8 +1538,10 @@ void mt7921_pm_wake_work(struct work_struct *work) mt76_connac_pm_dequeue_skbs(mphy, &dev->pm); mt76_worker_schedule(&mdev->sdio.txrx_worker); } else { + local_bh_disable(); mt76_for_each_q_rx(mdev, i) napi_schedule(&mdev->napi[i]); + local_bh_enable(); mt76_connac_pm_dequeue_skbs(mphy, &dev->pm); mt7921_mcu_tx_cleanup(dev); } -- 2.35.3