Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b59b922f96603468cbbe69b6359ec417083c526b.camel@perches.com>
Subject: Re: [PATCH v1 1/2] wireless: ray_cs: Utilize strnlen() in
 parse_addr()
From:   Joe Perches <joe@perches.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Date:   Fri, 03 Jun 2022 09:50:55 -0700
In-Reply-To: <20220603164414.48436-1-andriy.shevchenko@linux.intel.com>
References: <20220603164414.48436-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-06-03 at 19:44 +0300, Andy Shevchenko wrote:
> Instead of doing simple operations and using an additional variable on stack,
> utilize strnlen() and reuse len variable.
[]
> diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
[]
> +	while (len > 0) {
> +		if ((k = hex_to_bin(in_str[len--])) != -1)
>  			out[i] = k;
>  		else
>  			return 0;

could be reversed and unindented

>  
> -		if (j == 0)
> +		if (len == 0)
>  			break;
> -		if ((k = hex_to_bin(in_str[j--])) != -1)
> +		if ((k = hex_to_bin(in_str[len--])) != -1)
>  			out[i] += k << 4;
>  		else
>  			return 0;

and here