Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp493983iof; Mon, 6 Jun 2022 07:22:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1r0GXRAGsjdhUdG03bG/LDNq8uNmO9xaEG4RbGfgLWlcfwgh8OyRBrmEHPg3AbJpHCOOI X-Received: by 2002:a63:305:0:b0:3fc:7f18:8d7 with SMTP id 5-20020a630305000000b003fc7f1808d7mr21199424pgd.186.1654525368643; Mon, 06 Jun 2022 07:22:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654525368; cv=none; d=google.com; s=arc-20160816; b=waz0qh91sKJ9tRoV/kxpdsqQB7RSnsBQoYdXdHhNYVNlP9WvForMDfnxz9sRLEMJ8u 2cyNGY6NIOMkijkNWZ7hVoK7+icVtUanYh2OQYjqAELfPNrnG2T6YbBgy0HEF6fwoOBt XOU/kFMi/izEbb7OVXnBIJ62Mxm/2V97E1wlM0qlKDdkWI2B7rJM6wbVOAOBtNE+ewr1 5bGohEmfk3Sd9Rt6N3i3jimTHS2UygCM437fp8NI+FSzmRZWax28p535OdcyVVJM74SG fS2F7yhl8pmDia1K16/4ThkRJNdPW/G5LnpeSVQWfKsJOVFC9pIwue91hJlzHYOG/47N F5MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=au16eOgTC5Y27pzT/KOpW6K7zC8ZbkpurqdCA5wSXNg=; b=A+/5ERwcmEQkLsZy76y/x4DS2H2Q9GwyP3sXGSi6uSm8i78ogTrKybNHxKpCj/oQOl sCYy38+oLg43h1JLF443I4tugGO8S9a8YB2sTjXBYOW77N/wzCERvvH8NmeiS5f5bV2y +zpWk5XBIdQp1qxkWDO/uLQBbuH4Wv2fKryODMq5uu2MDiGtaSQH3n9bsFrrNZnWRZU8 yQeLrHMWqlc9X4cbnEn7hB9DcDODl4TwWfs+zeZ2rcF3p47qdubfJogaykMBEh2pqzqr WJZQYu9FxWVwgCbZgFaATmO1PS0dqFgbrIuY/C4gGnu9oS2Ol4PcyM97O2WRix5fn38b MfsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OaWnneUj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id a187-20020a6390c4000000b003f60df49265si20509190pge.326.2022.06.06.07.22.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 07:22:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OaWnneUj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 86E2B1D0E4; Mon, 6 Jun 2022 07:09:00 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239376AbiFFOI6 (ORCPT + 67 others); Mon, 6 Jun 2022 10:08:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238043AbiFFOI4 (ORCPT ); Mon, 6 Jun 2022 10:08:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B86591CF for ; Mon, 6 Jun 2022 07:08:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6895FB819F8 for ; Mon, 6 Jun 2022 14:08:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D62DC385A9; Mon, 6 Jun 2022 14:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654524533; bh=D0nfxgkU1zrBljYHyZkn5gGyrYOdvPSzjiXG5oFDjTk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=OaWnneUjkvytyScrO84+4eZ5Fx7jyuBNFOuMR2Ch2X3w+ooU9iorATsgwcicz96PI 6DyEBusDL1M+Z5TDZ97ss0CzcbMBeJWjpPKCCcgTfxRFDhYcNCzUusvAhhuh0LXnCT tWHb8ogLckN6aWaHfeHo5jPVzFPurTbHcVB1UT9C9ivg92u9UHb7ue4o5f+hNOkCVy aAgf7YREEwz59vhgzzofwd+tlh6+laAogXC3AIGnyHWnilAy1WN7ra44FmZowSdGbm 82BnxAiBbswSTY0eqCFAYpTjgKaZOPOxZEvsDTZkz5jQTLinrOBvZRbWmrARE3vykR 6dflpyGyNfilQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: Fix incorrect debug_mask mappings From: Kalle Valo In-Reply-To: <20220602115621.15339-1-quic_mpubbise@quicinc.com> References: <20220602115621.15339-1-quic_mpubbise@quicinc.com> To: Manikanta Pubbisetty Cc: , , Manikanta Pubbisetty User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <165452452992.15301.3587479774647912453.kvalo@kernel.org> Date: Mon, 6 Jun 2022 14:08:51 +0000 (UTC) X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Manikanta Pubbisetty wrote: > Currently a couple of debug_mask entries are mapped to the same value, > this could enable unintended driver logging. If enabling DP_TX logs was > the intention, then this could also enable PCI logs flooding the dmesg > buffer or vice versa. Fix this by correctly assigning the debug masks. > > Found during code review. > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1 > > Fixes: aa2092a9bab3f ("ath11k: add raw mode and software crypto support") > Signed-off-by: Manikanta Pubbisetty > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 9331f7d3c54a ath11k: Fix incorrect debug_mask mappings -- https://patchwork.kernel.org/project/linux-wireless/patch/20220602115621.15339-1-quic_mpubbise@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches