Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ath11k: Fix LDPC config in set_bitrate_mask hook
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20220602124142.29909-1-quic_mpubbise@quicinc.com>
References: <20220602124142.29909-1-quic_mpubbise@quicinc.com>
To:     Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Cc:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <165452464285.15301.12888477923740045977.kvalo@kernel.org>
Date:   Mon,  6 Jun 2022 14:10:48 +0000 (UTC)
Precedence: bulk

Manikanta Pubbisetty <quic_mpubbise@quicinc.com> wrote:

> Currently ar->ht_cap_info is not set anywhere in the code, this could
> result in LDPC config computed wrongly in the set_bitrate_mask() hook
> and eventually sending wrong config to the target. Fix this by checking
> the LDPC support from the band HT capabilities of the radio instead.
> 
> Furthermore, it looks like firmwares running on the ath11k hardware
> do not set WMI_HT_CAP_LDPC for advertising the TX LDPC capability,
> WMI_HT_CAP_TX_LDPC is set instead and this should be checked for
> getting hardware's TX LDPC support. This is true for QCA6390, WCN6855
> & WCN6750 hardware.
> 
> Also, remove unused variables ht_cap_info & vht_cap_info from
> struct ath11k{}.
> 
> Found this during code review.
> 
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
> 
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

4c1fc4f60a53 ath11k: Fix LDPC config in set_bitrate_mask hook

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220602124142.29909-1-quic_mpubbise@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches