Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp494305iof; Mon, 6 Jun 2022 07:23:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/mBup5a92IT/7y8p9tHVZnkJMpiR4Dw48BqI/KxZQWfF+v25Q5tH1P8d3xMyDO6RrzDzu X-Received: by 2002:a17:902:8a91:b0:167:621f:9749 with SMTP id p17-20020a1709028a9100b00167621f9749mr12514349plo.9.1654525375640; Mon, 06 Jun 2022 07:22:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654525375; cv=none; d=google.com; s=arc-20160816; b=fwlqgIQYLPXLeBkDhng39JxHVvMqIJMRgEvgB2gFxVC5jomegoZEOaY0nXYx0zZeue MXqTFprWjmlj7rPKM42sk+G2O15erDP/SRMHq349C7A+lgXXweeCdO7RMnNag0E3K9MH weUVM7jXbyxKa0rqX9zKG342BMiVH9oO2ZcFIPBKt76C0yMWle2oNjTgiveWeR2ulgoB wcuQviSllcYgeYZ/7cnatZZU8t9aDh5rD284/go3dejFeE+0I5e+Q0P+1jzbHbJhAqav 4QoEhlCVsnmXCmzyRcPWDjzNRhyQo969fD4tt5p5ykdFIseFEvsg9PfvwJJV9qG9tf0F Eu5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=bT3KhFX2KmHPUoTF4OkQwm9zja4tJNvuUD16/FfPF28=; b=UwgXYI6sLtFgzwP3jYjwNYYi7nYwlw2Dg23P8HihXy7RK4ANPsMMKFAU3+yjXJUSB0 grt55redrBLB5kYpzYqG6jv+E/PTPNKlrvfC0PzgdeM7Gi8idvMHJpj74jjNDDpmB2Z2 QCob4qClFBOKU2PeINX9DHnNSCA+p2iOW+vPa5c2NwW1LZbcDWplslG4bpyIcB71iUtj D7ssaZMdqBccPrzHaaJVIPcMC8IdUGK9WPhrqCSiJJCkXPg3NZP6//z4EFjRTT/HZhUR hUWyvBjm/MKrUmv1nibOapgAikSL9IrOAMQRXOZYXpx0xMov5epiniEhS4YCL+lSZIeh 0szg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="PQ/yd1lQ"; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d13-20020a056a00244d00b0051b3a927ad4si20292401pfj.289.2022.06.06.07.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 07:22:55 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="PQ/yd1lQ"; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BA16A24972; Mon, 6 Jun 2022 07:09:41 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239393AbiFFOJj (ORCPT + 67 others); Mon, 6 Jun 2022 10:09:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238043AbiFFOJi (ORCPT ); Mon, 6 Jun 2022 10:09:38 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD4092228F for ; Mon, 6 Jun 2022 07:09:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 23024CE1B8F for ; Mon, 6 Jun 2022 14:09:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53A01C385A9; Mon, 6 Jun 2022 14:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654524573; bh=xOo5DWzZui20CIsgcscdrFQMIfcx26XVOfbAkUjR34E=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=PQ/yd1lQZR0tpO0Xk/XlcK8k7gHS7aNH5dEm/oZbAt62gSM4j8L64a4c2rJtL0hPn aKb/SekUi6YWQ8h7CJYHr2wCEbw6BUmIA9nrtyVg7miGquM0+T4Fpjy0KTeR4fZQpT K2O9qA4DZFhYqpGdoPgVmAL0EhdxD74VKk8vhanMFi3dVSWQCK5qBM6SaCrTSZep3Y y1khFUFfQM8MewFGRq+OwSk1ixhpiYjkFfs/cywYC/EO6YzOk7yfnCaWqk0VdBjdRu vT1D3yHS4ZRBcJWQBS9QCc4sncDUQ23+qoqjeu+b07q18TlCm8JITxauUxPjQlILTp H2jg8V667WOEg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: Avoid REO CMD failed prints during firmware recovery From: Kalle Valo In-Reply-To: <20220602122929.18896-1-quic_mpubbise@quicinc.com> References: <20220602122929.18896-1-quic_mpubbise@quicinc.com> To: Manikanta Pubbisetty Cc: , , Manikanta Pubbisetty User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <165452456971.15301.3255857087699251778.kvalo@kernel.org> Date: Mon, 6 Jun 2022 14:09:32 +0000 (UTC) X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Manikanta Pubbisetty wrote: > Currently when firmware recovery is in progress, we do not queue REO > commands to the firmware, instead -ESHUTDOWN will be returned to the > caller leading to a failure print on the console. The REO command in > the problem scenario is sent for all tids of a peer in which case we > will have 16 failure prints on the console for a single peer. For an > AP usecase, this count would be even higher in a worst case scenario. > Since these commands are bound to fail during firmware recovery, it > is better to avoid printing these failures and thereby avoid message > flooding on the console. > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1 > > Fixes: 8ee8d38ca472 ("ath11k: Fix crash during firmware recovery on reo cmd ring access") > Signed-off-by: Manikanta Pubbisetty > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 0ab52b2bd7be ath11k: Avoid REO CMD failed prints during firmware recovery -- https://patchwork.kernel.org/project/linux-wireless/patch/20220602122929.18896-1-quic_mpubbise@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches