Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2198087iof; Tue, 7 Jun 2022 22:58:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxymg+DtzLbwBJ+I5bF2bo5RlSPutHHYeIxjgDJaBHjp8TFRSmwQyxGd7qkBUhdO3DHTDSf X-Received: by 2002:a17:90b:3507:b0:1e3:4b80:5c7a with SMTP id ls7-20020a17090b350700b001e34b805c7amr36043010pjb.4.1654667882363; Tue, 07 Jun 2022 22:58:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654667882; cv=none; d=google.com; s=arc-20160816; b=ZXVda6K0ZtXoIJcziT80n3kmEKGtB2odD2+6tmQM0jLfw+pzPRZdTVpY9UwQCmg9M3 7PHexVAF+pQFJDAI4h13SDYu7Xg9lqPShzsuU5mrHhZ1c5PnTn/cTSrqUpDlO+RUhRbg rbSQZf+TlaXcj5kTuQRDAU5dEJWm+c4g9DUhze7D8rEqjLPmW7guy3Hn0xrDk2A2kbnZ DjbgCUYfn5mYYQUPSCL26NbZhsd3K0IB8AAshcBHz/mY8PWzHEDfngImTuCXU0/uc7Dx nb2b2AA5/g/hg/1B1NE9Nl4T4VSbKxJI1ReO5BfMiatBi3BTNTCOaTkeR+ctXS2+iJSK teow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=o8U1S34GDx0bHp0NhWMtizvlqLqdERNlNdyKzmkx4+U=; b=01bMdYUAiqEv4UTL5tpxAThj1hPPyeEvDBqOioL1Ipp4bxLeH1Oh6+aDx8B+bHs9Rc FGRiosqIBJHst+N3hOHE+cbv+ZBqH6C2O5bgcV4cBG9Dpe6RTyzNirWnNLeaFgO2c8G5 wBOHhmAPIREJLcnU0rAFESW7ssYArLEthIFbMR90Ucep3qSEXt1LtDB5LA3igvG3I3p+ XFQDWxnTVBGC6b2iRhgDOYypEN3CXv4b9g7ZLVrHbXi+MlqVsz/FFpBt1HnW1paBSoPA hwzcoSBfnGa4VDanfIhEY8LB5X8azN5HB/nA/kdwPtR2xWztN/HYq2SlYWdBlVoOiYSJ WLVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=by6D4BCY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id y7-20020a17090a644700b001e2734dc84csi28229954pjm.184.2022.06.07.22.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 22:58:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=by6D4BCY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 722484B6CA5; Tue, 7 Jun 2022 22:23:40 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236052AbiFHBDe (ORCPT + 67 others); Tue, 7 Jun 2022 21:03:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1457146AbiFGXV0 (ORCPT ); Tue, 7 Jun 2022 19:21:26 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADBB53E28BE for ; Tue, 7 Jun 2022 14:25:41 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id i66so25580884oia.11 for ; Tue, 07 Jun 2022 14:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to; bh=o8U1S34GDx0bHp0NhWMtizvlqLqdERNlNdyKzmkx4+U=; b=by6D4BCYbgD+YVeH1LV9bok7CXSN7M3sM9x/DzG+WRKCeNvODXctf1UMvrv3TJpx45 a2oFS8tMKxKY8RHt4DMYyVqU8tt/8ZX4E0BixrDU/rJumwo5qzgtAu+LUJlaa3dYOrj0 tDNL7EpzYTNtZBrnBoExIj2qvrjn2o+9a+bhAx5iy/1nqZIUSE8jTi8z9QT5vKiWxB3o hotXE6DqSUDZ+qP8yFDYx/9h1rY1dMVgLcxautQG9dyZEjanQzo397/cjfnwf2ihOnZE fCFYE2utUq3tqxy8O5rCjfxiu2aZFggu8Rk3bD5NhgiDxVkFDUZz4r4TCg8/QzmAX+2K /iIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to; bh=o8U1S34GDx0bHp0NhWMtizvlqLqdERNlNdyKzmkx4+U=; b=S//DFnA7yGdzqbg82jCuUR0a2tasGikn87jA02RiQuq5fYRdIZzsHz7Mk+CptcwGgW eyZJs/B03SF+2ye02MkEpUNrRK9iUOVctO8WY6nfbm1TezBToYfFiXs7LFM6G/6v27x9 zNkAxZGg9NGSATEGUBru9MYNMOK4V5rabrg9uPgwTPcwDZ6Ir6hLW8XhX7blX8KWJ0V+ bF8ftc37mZovsiQ+mxu4E7sjmh8oQudKscuj2dX6x6NM6NLujsoMkvGD7FXrvbwAagqh pnbxGuw8cnl1LiXSw9Rz7USQlfdkXKJqOO3Bnnt70vfVwtRNvuk5EIRKFfOdRP2uNSNw UIcA== X-Gm-Message-State: AOAM532L20Pc/NVp/qsXZqz64Sh+hY3I/WIwStBdgfBoeMX82zZ4i5a4 xo5D1EMJeYu+3Ir7YmjmD2eAhUQLfpg= X-Received: by 2002:a05:6808:f0f:b0:32b:a0a3:9618 with SMTP id m15-20020a0568080f0f00b0032ba0a39618mr549505oiw.264.1654637140395; Tue, 07 Jun 2022 14:25:40 -0700 (PDT) Received: from ?IPV6:2603:8090:2005:39b3::100e? (2603-8090-2005-39b3-0000-0000-0000-100e.res6.spectrum.com. [2603:8090:2005:39b3::100e]) by smtp.gmail.com with ESMTPSA id w5-20020a056808140500b00326cb6225f8sm10917063oiv.44.2022.06.07.14.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 14:25:39 -0700 (PDT) Sender: Larry Finger Content-Type: multipart/mixed; boundary="------------YrgDnoQ1hV7DXXiBBUtxqYaH" Message-ID: Date: Tue, 7 Jun 2022 16:25:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 4/4] rtw88: Fix Sparse warning for rtw8821c_hw_spec Content-Language: en-US To: Nathan Chancellor Cc: Kalle Valo , Johannes Berg , linux-wireless@vger.kernel.org, Ping-Ke Shih References: <20220524153716.20450-1-Larry.Finger@lwfinger.net> From: Larry Finger In-Reply-To: X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This is a multi-part message in MIME format. --------------YrgDnoQ1hV7DXXiBBUtxqYaH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/7/22 14:05, Nathan Chancellor wrote: > Hi Larry, > > On Tue, May 24, 2022 at 10:37:16AM -0500, Larry Finger wrote: >> Sparse lists the following: >> >> CHECK drivers/net/wireless/realtek/rtw88/rtw8821c.c >> drivers/net/wireless/realtek/rtw88/rtw8821c.c:1880:22: warning: symbol 'rtw8821c_hw_spec' was not declared. Should it be static? >> >> The warning arises because the external declaration for rtw8821c_hw_spec >> occurs in rtw8821ce.h, which is not included in rtw8821c.h. That line is >> moved, and the now empty file rtw8821ce.h is deleted. >> >> Symbol 'rtw8821c_hw_spec' can be made constant. >> >> Signed-off-by: Larry Finger > > I bisected this change as commit 89d8f53ff6e7 ("wifi: rtw88: Fix Sparse > warning for rtw8821c_hw_spec") in linux-next as the cause of one of my > test machines failing to boot with the following stacktrace: > > BUG: unable to handle page fault for address: ffffffffc09f52f4 > #PF: supervisor write access in kernel mode Nathan, Thanks for your excellent report. Does the attached patch fix your issue? Larry --------------YrgDnoQ1hV7DXXiBBUtxqYaH Content-Type: text/x-patch; charset=UTF-8; name="0001-rtw88-Fix-BUG-in-rtl8821ce.patch" Content-Disposition: attachment; filename="0001-rtw88-Fix-BUG-in-rtl8821ce.patch" Content-Transfer-Encoding: base64 RnJvbSBmNmIwMmJiZTk1YzA0MDJmYjIzNzhhNTRlNTRkYjllMGNjNDU4N2RkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBMYXJyeSBGaW5nZXIgPExhcnJ5LkZpbmdlckBsd2Zp bmdlci5uZXQ+CkRhdGU6IFR1ZSwgNyBKdW4gMjAyMiAxNjoxNTowNyAtMDUwMApTdWJqZWN0 OiBbUEFUQ0hdIHJ0dzg4OiBGaXggQlVHIGluIHJ0bDg4MjFjZQpUbzogS2FsbGUgVmFsbyA8 a3ZhbG9Aa2VybmVsLm9yZz4KQ2M6IEpvaGFubmVzIEJlcmcgPGpvaGFubmVzQHNpcHNvbHV0 aW9ucy5uZXQ+LAogICAgbGludXgtd2lyZWxlc3NAdmdlci5rZXJuZWwub3JnCgpJbiBjb21t aXQgODlkOGY1M2ZmNmU3ICgid2lmaTogcnR3ODg6IEZpeCBTcGFyc2Ugd2FybmluZyBmb3IK cnR3ODgyMWNfaHdfc3BlYyIpLCBydHc4ODIxY19od19zcGVjIHdhcyBpbmNvcnJlY3RseSBt YWtlIGNvbnN0CnRvIHNpbGVuY2UgYSBTcGFyc2Ugd2FybmluZy4KCkZpeGVzOjg5ZDhmNTNm ZjZlNyAoIndpZmk6IHJ0dzg4OiBGaXggU3BhcnNlIHdhcm5pbmcgZm9yIHJ0dzg4MjFjX2h3 X3NwZWMiKQpSZXBvcnRlZCBieTogTmF0aGFuIENoYW5jZWxsb3IgPG5hdGhhbkBrZXJuZWwu b3JnPgpTaWduZWQtb2ZmLWJ5OiBMYXJyeSBGaW5nZXIgPExhcnJ5LkZpbmdlckBsd2Zpbmdl ci5uZXQ+Ci0tLQogZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9ydHc4ODIx Yy5jIHwgMiArLQogZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9ydHc4ODIx Yy5oIHwgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4 OC9ydHc4ODIxYy5jIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9ydHc4 ODIxYy5jCmluZGV4IDQyODQxZjVkNTAyYy4uZmZlZTM5ZWE1ZGY2IDEwMDY0NAotLS0gYS9k cml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0dzg4L3J0dzg4MjFjLmMKKysrIGIvZHJp dmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9ydHc4ODIxYy5jCkBAIC0xODc3LDcg KzE4NzcsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJ0d19yZWdfZG9tYWluIGNvZXhfaW5m b19od19yZWdzXzg4MjFjW10gPSB7CiAJezB4NjBBLCBNQVNLQllURTAsIFJUV19SRUdfRE9N QUlOX01BQzh9LAogfTsKIAotY29uc3Qgc3RydWN0IHJ0d19jaGlwX2luZm8gcnR3ODgyMWNf aHdfc3BlYyA9IHsKK3N0cnVjdCBydHdfY2hpcF9pbmZvIHJ0dzg4MjFjX2h3X3NwZWMgPSB7 CiAJLm9wcyA9ICZydHc4ODIxY19vcHMsCiAJLmlkID0gUlRXX0NISVBfVFlQRV84ODIxQywK IAkuZndfbmFtZSA9ICJydHc4OC9ydHc4ODIxY19mdy5iaW4iLApkaWZmIC0tZ2l0IGEvZHJp dmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9ydHc4ODIxYy5oIGIvZHJpdmVycy9u ZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9ydHc4ODIxYy5oCmluZGV4IDI2OTg4MDFmYzM1 ZC4uNGY3NjkzN2RhNGVmIDEwMDY0NAotLS0gYS9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFs dGVrL3J0dzg4L3J0dzg4MjFjLmgKKysrIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRl ay9ydHc4OC9ydHc4ODIxYy5oCkBAIC04NCw3ICs4NCw3IEBAIF9ydHdfd3JpdGUzMnNfbWFz ayhzdHJ1Y3QgcnR3X2RldiAqcnR3ZGV2LCB1MzIgYWRkciwgdTMyIG1hc2ssIHUzMiBkYXRh KQogCXJ0d193cml0ZTMyX21hc2socnR3ZGV2LCBhZGRyICsgMHgyMDAsIG1hc2ssIGRhdGEp OwogfQogCi1leHRlcm4gY29uc3Qgc3RydWN0IHJ0d19jaGlwX2luZm8gcnR3ODgyMWNfaHdf c3BlYzsKK2V4dGVybiBzdHJ1Y3QgcnR3X2NoaXBfaW5mbyBydHc4ODIxY19od19zcGVjOwog CiAjZGVmaW5lIHJ0d193cml0ZTMyc19tYXNrKHJ0d2RldiwgYWRkciwgbWFzaywgZGF0YSkJ CQkgICAgICAgXAogCWRvIHsJCQkJCQkJCSAgICAgICBcCi0tIAoyLjM2LjEKCg== --------------YrgDnoQ1hV7DXXiBBUtxqYaH--