Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <a2cc93f959394a3430755d4664d9f2abeabb3ab7.camel@sipsolutions.net>
Subject: Re: [RFC v2] cfg80211: Indicate MLO connection info in connect and
 roam callbacks
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Veerendranath Jakkam <quic_vjakkam@quicinc.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Wed, 08 Jun 2022 09:31:03 +0200
In-Reply-To: <1654536690-12588-1-git-send-email-quic_vjakkam@quicinc.com>
References: <1654536690-12588-1-git-send-email-quic_vjakkam@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-06-06 at 23:01 +0530, Veerendranath Jakkam wrote:

> +	if (cr->status =3D=3D WLAN_STATUS_SUCCESS) {
> +		for_each_valid_link(cr, link) {
> +			if (!cr->links[link].bss)
> +				break;
> +		}
> +
> +		WARN_ON_ONCE((!cr->valid_links && link !=3D 1) ||
> +			     (cr->valid_links &&
> +			      link !=3D ARRAY_SIZE(wdev->links)));
> +

I will say I'm not super happy with using the link variable after the
loop, that always feels a bit magic to me, especially if the loop is
hidden like that...

But I guess I don't see a lot of alternatives here, other than open-
coding it, or keeping track of "how many BSSes do I have".

Actually, for the MLO case, is this even valid? link[14] could be set,
so you wouldn't break, ending up with link=3D=3D15? Or am I confused?

Anyway, looks good to me.

johannes