Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <e75ddf50-348b-eaf2-4033-6a32ef65a41c@quicinc.com>
Date:   Wed, 8 Jun 2022 13:15:01 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [RFC v2] cfg80211: Indicate MLO connection info in connect and
 roam callbacks
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>
CC:     <linux-wireless@vger.kernel.org>
References: <1654536690-12588-1-git-send-email-quic_vjakkam@quicinc.com>
 <a2cc93f959394a3430755d4664d9f2abeabb3ab7.camel@sipsolutions.net>
From:   Veerendranath Jakkam <quic_vjakkam@quicinc.com>
In-Reply-To: <a2cc93f959394a3430755d4664d9f2abeabb3ab7.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/8/2022 1:01 PM, Johannes Berg wrote:
> On Mon, 2022-06-06 at 23:01 +0530, Veerendranath Jakkam wrote:
>
>> +	if (cr->status == WLAN_STATUS_SUCCESS) {
>> +		for_each_valid_link(cr, link) {
>> +			if (!cr->links[link].bss)
>> +				break;
>> +		}
>> +
>> +		WARN_ON_ONCE((!cr->valid_links && link != 1) ||
>> +			     (cr->valid_links &&
>> +			      link != ARRAY_SIZE(wdev->links)));
>> +
> I will say I'm not super happy with using the link variable after the
> loop, that always feels a bit magic to me, especially if the loop is
> hidden like that...
>
> But I guess I don't see a lot of alternatives here, other than open-
> coding it, or keeping track of "how many BSSes do I have".


Since we need to WARN even if single BSS is not present I think we can 
use "bss_not_found" flag?

>
> Actually, for the MLO case, is this even valid? link[14] could be set,
> so you wouldn't break, ending up with link==15? Or am I confused?
In MLO case the link value will be always 15 after loop completes if 
bsses are available for all valid links since the check is only for the 
valid links

so, In above case also when "link==15" the condition fails and WARN will 
be skipped right.


> Anyway, looks good to me.
>
> johannes