Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1144132iol; Fri, 10 Jun 2022 00:53:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymflyA+kJDUJwE0HO5RGRMM+lAbYuw8S4N6ni9eEAJYVvyBjo2eZN2khWcNF6iRqAF75GE X-Received: by 2002:a17:902:eb85:b0:167:8dcb:2003 with SMTP id q5-20020a170902eb8500b001678dcb2003mr20326651plg.121.1654847591803; Fri, 10 Jun 2022 00:53:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654847591; cv=none; d=google.com; s=arc-20160816; b=T7k5WuTZL02I7Tjj+Bf7s25DWDNMIoMTXipvfkButL5zQach72oDfgQe9kT1gM+ONl XgEdfptuNqXCEVV5463OJoBD6NBKDjDcdWiDnJgiUkV22oCqcfDmakavPzHUedYhpX33 H+37TM1wgRk6dVnnUS5jtrjYhcaiVrerHHTZD6njz5oO2Tgmhppd4kXq3lO5gqKBXs2R dU5cc6JkfwcJY3hKBXKp5+JUT1CsiK8jAHrztejxJ9VIAg+HTwELDlSlCFEGUVOYEIUq 6Lx5+SVLJpISK8403uyk1GPKlxLVNjPKINcHIdFKPv1OzbcW6PuJCnXF8AbrjdsATYTT yibw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=wCVwDdIPiZYW43/9IAWQQdjXXP+sWCmdBlGdicbArSc=; b=tgDh1KF+B16lbv+PMnom7IlQXrh4bACw6+oNQ6fWsq32ibSWm+eShy1pARL4Onw6Jd JluIjrj3VcpYLCH1TeeOV/gCdNnG65o/5NM0mJ2NnY04eue5DhEzBI71PqbL1sPpL25p TT066mxtupHKusQw05BMpp9RFxiM6LXxgxjto2ulctw1lUjekH7QcddGeoAAgvM1KChd T68XByVzSUopzbMurbgPxKeDzY5VTql8GTa1c+pHfKjbj9XIRfLhhrAiCmPJ7s2rqJWo QlTtfpG//7tGNSDDa57WLZH+lLYD3kf9Q7E/lZJ35ii0d6TW3HE7WGetQu8A63h6CDXs Tw/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D4uf040V; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r5-20020a170902be0500b00153b2d1663bsi1544690pls.579.2022.06.10.00.52.56; Fri, 10 Jun 2022 00:53:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D4uf040V; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346826AbiFJHjZ (ORCPT + 65 others); Fri, 10 Jun 2022 03:39:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242965AbiFJHjY (ORCPT ); Fri, 10 Jun 2022 03:39:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBFF3132766; Fri, 10 Jun 2022 00:39:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A5A78B831CF; Fri, 10 Jun 2022 07:39:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0E8AC3411B; Fri, 10 Jun 2022 07:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654846761; bh=hCht15CTX44Sxk0pUcKGojtW+Cz5f/KZ5jdF4JOrrho=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=D4uf040VQO4M09A8PXRpNKasuCp1C/MOzTMav9sOMCmqRbhu/MiZdTLL3FfuXszpj Fnw8puVMUizdbPAyVg9zTNgvz7TA0NwUA1QKurIYTCkBQ+rDpu30xr4XA+8X+Wl6hU fNpdtGPsY86G0L9fMqKJQvkWcWxrlcih/5rJBsuf3MIsI7qvT3SWEeeRpDyfE2t8we KEsZ+Bi3pJcNyaO9RWLbiPWg1P5zqMFYzoFiSV9xLp3DRRpD8IM8UxUBSKkIlfckcs rSAKClt9RaW8tUz0+MwQ78FTyTlVqoHXxRHLEgx9U+FQdT2GHkLf0Thop4dItQ50Ng ulpIq0spROH7g== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: wifi: wfx: Remove redundant NULL check before release_firmware() call From: Kalle Valo In-Reply-To: <20220606014237.290466-1-chi.minghao@zte.com.cn> References: <20220606014237.290466-1-chi.minghao@zte.com.cn> To: cgel.zte@gmail.com Cc: jerome.pouiller@silabs.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <165484674004.24214.13068275820248967076.kvalo@kernel.org> Date: Fri, 10 Jun 2022 07:39:18 +0000 (UTC) X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org cgel.zte@gmail.com wrote: > From: Minghao Chi > > release_firmware() checks for NULL pointers internally so checking > before calling it is redundant. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > Acked-by: Jérôme Pouiller Patch applied to wireless-next.git, thanks. 05a2eebfa650 wifi: wfx: Remove redundant NULL check before release_firmware() call -- https://patchwork.kernel.org/project/linux-wireless/patch/20220606014237.290466-1-chi.minghao@zte.com.cn/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches