Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
To:     Pavel Skripkin <paskripkin@gmail.com>,
        Hillf Danton <hdanton@sina.com>
Cc:     linux-wireless@vger.kernel.org,
        syzbot+c6dde1f690b60e0b9fbe@syzkaller.appspotmail.com
Subject: Re: [PATCH v5 1/2] ath9k: fix use-after-free in ath9k_hif_usb_rx_cb
In-Reply-To: <2ee8f6fc-aec1-39a6-e8db-56e5e449ee8e@gmail.com>
References: <20220522041542.2911-1-hdanton@sina.com>
 <2ee8f6fc-aec1-39a6-e8db-56e5e449ee8e@gmail.com>
Date:   Fri, 10 Jun 2022 20:30:27 +0200
Message-ID: <87pmjg2wxo.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

[ This had the wrong mailing list in Cc, adding back linux-wireless ]

Pavel Skripkin <paskripkin@gmail.com> writes:
> Hi Hillf,
>
> On 5/22/22 07:15, Hillf Danton wrote:
>> 
>> In the call chain below
>> 
>> 	ath9k_hif_usb_firmware_cb()
>> 	  ath9k_htc_hw_alloc()
>> 	  ath9k_hif_usb_dev_init()
>> 	  ret = ath9k_htc_hw_init()
>> 	          ath9k_htc_probe_device()
>> 		    htc_handle->drv_priv = priv;
>> 		    ret = ath9k_htc_wait_for_target(priv);
>> 		    if (ret)
>> 			goto err_free;
>> 	  if (ret)
>> 		goto err_htc_hw_init;
>> 
>> err_free:
>> 	ieee80211_free_hw(hw);
>> 
>> 
>> err_htc_hw_init:
>> 	ath9k_hif_usb_dev_deinit(hif_dev);
>> 	  ath9k_hif_usb_dealloc_urbs()
>> err_dev_init:
>> 	ath9k_htc_hw_free(hif_dev->htc_handle);
>> err_dev_alloc:
>> 	release_firmware(fw);
>> err_fw:
>> 	ath9k_hif_usb_firmware_fail(hif_dev);
>> 
>> 
>> hw should survive deallocating urbs, and changes should be added instead to
>> the rollback in ath9k_htc_probe_device() by deferring cleanup of hw to its
>> callsite in addition to urbs.
>> 
>
> Don't get it, sorry. I am not changing the life time of `hw`, I am just 
> deferring htc_handle->drv_priv initialization.
>
>
>
>
> With regards,
> Pavel Skripkin