Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1146714iog; Mon, 13 Jun 2022 23:19:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLYCB+pLZudUkX28USRwOX9s0L8wfnLXvmNQFZFRU0HbQnMEONBln9W8PyZ8QLSlju81E7 X-Received: by 2002:a05:6402:27cf:b0:431:54d9:28ed with SMTP id c15-20020a05640227cf00b0043154d928edmr3916378ede.81.1655187543083; Mon, 13 Jun 2022 23:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655187543; cv=none; d=google.com; s=arc-20160816; b=cybtw84xYcxQUWvKrsbD2SyO9WeJtr0WPON5ffFFPAMWNNbPtFpxCQir+JLQsGUgwO I8YRpNDKn/ehcwdWMVkXGQHJ6sBOvzo+fYw2JVg+zdLtczWAdP2c5TbvHcTjBht6Odnt cuojhDAQ0+w9y6dO8oWd8e9HlGrbX80JTD+iZ16wbHxZ2HaYawZ/EInhbb3ELaivLaEo H+yomIJEhHBbkRK5y2Ikl3D+w7VOtY6hIhz+CBBazhEwMKFEN0YvqtZlPahQGLjjlTTd ss7XwwTibQsqLJfXGjQIM8JeZREWp0RH2LKOb9x/3V4nh+GUEVyoDdJ/X4CtAyCMhHrK TUfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=dVjtNat7hoBBLObKHQ+9neiop5m/IJG1JLKCTvLRmok=; b=iusMrInVRJWuWjUS2TZX+wevdz+RDIXCXRMVxOyY2x1C97YiG9r9YK6GsMUpZc+We4 tdCcIGEAeUgHDm8CarUfLsg6gX4bE//MFZo8a7s+n2cXWV7KZciBz1G+tWaD8P1TZImI cN3onOLVxFR0M+br0O+A1A9z9cyVbQQwdkpD1aGVmPEpuOTPiAe7nCLzf0pqDH2Ue5Lk i1n/rRPHwqqBYZzJKDOuO9ip7HfTTHr/9ksqwtLZrZoKeEc7BJ3tcnXmRj2QmPq3OG9u BRTWIY7EOjVXrgyzM8rbTHh5V5w3HPEOfDdBp0wvCY7YL+HIA1p3mI8j54flytc9BkMb PNCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EN9q83Uh; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y27-20020a170906519b00b007157867106fsi8373697ejk.439.2022.06.13.23.18.39; Mon, 13 Jun 2022 23:19:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EN9q83Uh; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238756AbiFNGPl (ORCPT + 65 others); Tue, 14 Jun 2022 02:15:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbiFNGPj (ORCPT ); Tue, 14 Jun 2022 02:15:39 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 436D3377CF; Mon, 13 Jun 2022 23:15:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A6661CE182F; Tue, 14 Jun 2022 06:15:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4AB6C3411B; Tue, 14 Jun 2022 06:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655187335; bh=vo5JOYkEPeFEWpKNIvUVh541SRQIp5YhW0KwaowC1TE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EN9q83UhlB8dhqZIow1gnV9jnq1wtW6JSaaGpbPQFx1jpcnu9pWLvl/Ot00hUA5wz RJUDzPVu8bhWqMOjbaytQW1tBJYkzaiO2R4EMYyE9ckYuS3TJxtiUfT5mbDe9FE1c6 uCnE7cS3inwzREhYL1LOR1A45ULHJJOdk+G0r9iPi34UU7PHEBL0RlVOorQObAydno llQcgPxq3WUbPPzbiT6WQRGBehDIqXuO+7PSQVzpv9kJX4XnRLc6Femx/AAZXTsmEQ 3M8pTbe1A94HsYPT5DMqRPpd0HLaZGpYlahy8IhzIBtdHB6LQx+SLGJWz0tXJ+d2rM vhZulZ2tLmKFA== From: Kalle Valo To: Christophe JAILLET Cc: Christian Lamparter , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "John W. Linville" , linux-kernel , kernel-janitors@vger.kernel.org, Christian Lamparter , linux-wireless , Netdev Subject: Re: [PATCH v2] p54: Fix an error handling path in p54spi_probe() References: <297d2547ff2ee627731662abceeab9dbdaf23231.1655068321.git.christophe.jaillet@wanadoo.fr> Date: Tue, 14 Jun 2022 09:15:28 +0300 In-Reply-To: (Christophe JAILLET's message of "Mon, 13 Jun 2022 22:57:25 +0200") Message-ID: <871qvrrcsf.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Christophe JAILLET writes: > Le 13/06/2022 =C3=A0 22:02, Christian Lamparter a =C3=A9crit=C2=A0: >> On Sun, Jun 12, 2022 at 11:12 PM Christophe JAILLET >> wrote: >>> >>> If an error occurs after a successful call to p54spi_request_firmware()= , it >>> must be undone by a corresponding release_firmware() as already done in >>> the error handling path of p54spi_request_firmware() and in the .remove= () >>> function. >>> >>> Add the missing call in the error handling path and remove it from >>> p54spi_request_firmware() now that it is the responsibility of the call= er >>> to release the firmawre >> >> that last word hast a typo: firmware. (maybe Kalle can fix this in post= ). > > More or less the same typo twice in a row... _Embarrassed_ No worries, I can fix the typo. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes