Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 14 Jun 2022 10:25:05 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Christian Lamparter <chunkeey@gmail.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "John W. Linville" <linville@tuxdriver.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org,
        Christian Lamparter <chunkeey@web.de>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] p54: Fix an error handling path in p54spi_probe()
Message-ID: <20220614072505.GH2146@kadam>
References: <297d2547ff2ee627731662abceeab9dbdaf23231.1655068321.git.christophe.jaillet@wanadoo.fr>
 <CAAd0S9DgctqyRx+ppfT6dNntUR-cpySnsYaL=unboQ+qTK2wGQ@mail.gmail.com>
 <f13c3976-2ba0-e16d-0853-5b5b1be16d11@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f13c3976-2ba0-e16d-0853-5b5b1be16d11@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nNEKfb9K1OC6S6gjVpJeRf1LMF3JZbK/kcT0b0CSYbp2QxWGQ7w9De5bNt82?=
 =?us-ascii?Q?kmwXc9xW1K7XRYuyUKhbeoEciHF9+q+UQAOy0aanS4m4DGosM1CDNsCCR8Pd?=
 =?us-ascii?Q?gz793iZoDEhxu+/6zdEv8njmUAUKVQcSihJXz8vEK1w6X+0QxGGuIc9KnQdb?=
 =?us-ascii?Q?BmBKW7nv7ymeSwJyadQbqH4XxlXF8rE6p/EVf5UEINdHjffSxFss3D6IMi7V?=
 =?us-ascii?Q?T8rqvRzc0cuCmNpAhSJDsvHkZqLAORZ6B/TM3qHfaE6dTM5m/yaz5pWa94Jz?=
 =?us-ascii?Q?OABFR3IJCTcaH5RFmnQJBdlarxehkP1l6zG/ILNbN60LX8DhSlzZBNBOlUYO?=
 =?us-ascii?Q?nevedoaXAJuraanVmTqzu3IbLrLBzCLXYw2lKLuks+O/A6u2N2VuKiJGG6yO?=
 =?us-ascii?Q?bskYG1Y6ziIfGkYFNUVUH8PWVsc7b++pdJ5RJIxOHnOUlNNL1zhvBPPvHa2h?=
 =?us-ascii?Q?1sFtje4zPohHWlfYnVI2n+/7cNzB+UzkeoetSty6hdy53DZmZPxI/84G7ijS?=
 =?us-ascii?Q?aoBK6ZWziF9WDwOROASj/oZxaXx9W9PAxizGSyHajI3lfVRBGXJSs1+zs52P?=
 =?us-ascii?Q?dx/tpJUjyCIT7nsAD9p1Vo+giz7UIbi2LJ8rckU+kBi4UGafhvQBJrQ7dsSh?=
 =?us-ascii?Q?SNQL2+zywZg3OUivajNS/wj1MMuwEVVPSVgWE+4MHwd/HvuytycayVrxMJRN?=
 =?us-ascii?Q?F7k6HFCa8knaM/LrmrGCtOOrYBS84ps4wPpHQnje0ynvfASixxsyxMT2fzIR?=
 =?us-ascii?Q?AgZbCgtrVICU0pgBD+LF0xVDigHPvZkf82JDEB4RkmauL1W7Q/2ltQU7gorQ?=
 =?us-ascii?Q?an3t1S0fPYfJWLE1Ummg1pg0eAAKvxJ+G5K4iIO5FEWs2JE+Hi+IEZQbzC1W?=
 =?us-ascii?Q?NYWKPiuJLdIXM+TDpRr0cebTcKqbaBULAUE52LWnQntC7XrOObSKe0vc4Dx9?=
 =?us-ascii?Q?n7M6t9d32eRvvtn6zgyYQBnPQHGUz2eW+Xf72f/6VeAFOjVU0uZjnerct9p7?=
 =?us-ascii?Q?AjJkNjiDll9dm3zzfMyFYeqbtRoFAR/+q/jJQ4k1nmtWiFuqegmaabmkdVd8?=
 =?us-ascii?Q?AN+eh075XwF0RSBI6ekIOdV/QK/k0VB0OPq+UHc/goN2irHWnNjpgWueS0An?=
 =?us-ascii?Q?9ZTuo13H7uqSvziSnHapx2hr7vRQ8xxTpDi+SDu6iAbpRCop2dzHJFuAHukL?=
 =?us-ascii?Q?TXCK9NfBP4z6HhteYN+yFcMcerFHAypeP/GcJ6qjvytS2O52UHtez0v0kVK6?=
 =?us-ascii?Q?EeCF4989e0+AIAtToyrNPCY/tJ0l8d2lfq1yOcCyd3rIAB6R0aG3AgIZtame?=
 =?us-ascii?Q?7Wg4UGU1uPRUFSWrHg2mm9myLMMGABBqzUbLcpFX+9bBkGHDfQMzqxA1Ftuf?=
 =?us-ascii?Q?l+I33rbDB6K+tn/iGOIylzDVy2ZoMmUjTnjb9O3E7hov8zI8YtRjOvt+Zc71?=
 =?us-ascii?Q?mQSrXG7XnqruOmUFt4C6TLKrmam+CUpbGGYL+dnPlPH1ottQ5phCEeqO3Mp1?=
 =?us-ascii?Q?2yqpF9dgHaqTE9eA2RCtnPtx2dDUtN7PLSii2XJoxHDvk0bz3P8X24TV6ZWk?=
 =?us-ascii?Q?CBLCXHw9pBoBzQDJrduAyCrR7A6v2X+kfXKCpYvypKqhyGdIK0kQ4N0Lu79F?=
 =?us-ascii?Q?q/Vt0xt1RkoPC/MMdJWEV3IGkoFc2vlezeR+EOMXVqxmk+zDlTPLv2mNehZc?=
 =?us-ascii?Q?OjWcMFj4ykANintvAz87/ttB9mG+V1h2woqwgh8vN8fyVYllXte9wmMU3hdP?=
 =?us-ascii?Q?6/QbZ+oEL2m5ickX58rE7IEa9ac/dWk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1837cddf-1b59-4ebf-1781-08da4dd71c87
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 07:25:52.2800
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LHSr+cWysPxRuapY78k1M4kyN2f12XAPZoogfDPGNWPj9wEx/MDEIaSjpZH8W4w7QYj3A+W9pVDq7DoKrHaFfmuxH861e907hEyQsIhofww=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1548
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-14_02:2022-06-13,2022-06-14 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 suspectscore=0 adultscore=0 mlxlogscore=990 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206140028
X-Proofpoint-GUID: JgsZ-gBOeWW1eT2mfBtAX3Q6TMBVX5Ma
X-Proofpoint-ORIG-GUID: JgsZ-gBOeWW1eT2mfBtAX3Q6TMBVX5Ma
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, Jun 13, 2022 at 10:57:25PM +0200, Christophe JAILLET wrote:
> > > ---
> > > v2: reduce diffstat and take advantage on the fact that release_firmware()
> > > checks for NULL
> > 
> > Heh, ok ;) . Now that I see it,  the "ret = p54_parse_firmware(...); ... "
> > could have been replaced with "return p54_parse_firmware(dev, priv->firmware);"
> > so the p54spi.c could shrink another 5-6 lines.
> > 
> > I think leaving p54spi_request_firmware() callee to deal with
> > releasing the firmware
> > in the error case as well is nicer because it gets rid of a "but in
> > this case" complexity.
> 
> 
> Take the one you consider being the best one.
> 
> If it deserves a v3 to axe some lines of code, I can do it but, as said
> previously, v1 is for me the cleaner and more future proof.
> 

I prefered v1 but with s/firmaware/firmware/...

regards,
dan carpenter