Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 16 Jun 2022 10:54:24 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Arend van Spriel <aspriel@gmail.com>,
        Johannes Berg <johannes@sipsolutions.net>
Cc:     Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Kalle Valo <kvalo@kernel.org>, Len Baker <len.baker@gmx.com>,
        Shawn Guo <shawn.guo@linaro.org>,
        Hector Martin <marcan@marcan.st>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        Linus Walleij <linus.walleij@linaro.org>,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] brcmfmac: use strreplace() in brcmf_of_probe()
Message-ID: <YqrhsKcjEA7B2pC4@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SQKqoWoNmKFE3pH8Sip5oeazDp3hOGRsW2Ml3APp01thv664rgWNik6YZbEb?=
 =?us-ascii?Q?kFxXxNGwdc1N1G6mvhdbs5W14Ct2Dt9oTPDPbYVEWMgG26UvOUyEcHptJosp?=
 =?us-ascii?Q?+0K67dKG1kiTwIIRPFrWzzQz/Y+wZfBHFtrBympHMeogTt8ZnzNgqR68SmOj?=
 =?us-ascii?Q?KZbS3bGgQfKBmO2FscTG5X0Me9WE8ishqEjNs0/tuw9k98t7qryB169HokAI?=
 =?us-ascii?Q?Slbm4MnriXh73eZjBMAuqxYxa3NzWe2mM0rLeiXDH0xsi2Xf5ur+n68WsBqH?=
 =?us-ascii?Q?e2Jgt2CPya8drF/Ilav7g1G84SLhonnl7zldROTKnwVTjxsdjk2vL81HcFjs?=
 =?us-ascii?Q?+/Bb+o5Fo07D6Rx2CdBsaoAdGvAa4SGU+PEDzgJF/Efuiah6fNXcaSl53m1X?=
 =?us-ascii?Q?Fvce6+F7cvzjM/A0QUd9WNiqb3jvXSsvjJnOkNCS/tD6+ALFithJLsimA43s?=
 =?us-ascii?Q?XfpJjaqajB2Z+MQ92ZnkMoWvG2cvBQ1gQLDGCpme1GZviytCSuqgWhYQAYei?=
 =?us-ascii?Q?TChj+PqTBv/cCVzaZvePeNZ5b0GB0R8K8xlNfA2sZeRaTCX0cxpbvlJZzlKO?=
 =?us-ascii?Q?QB/Ke8/aBf+yaiEDr9xU0o5EQnMWS6AP69AWNMhFT5CaLnEdEePsdVHxQ2rF?=
 =?us-ascii?Q?6p079qDxBjwRnLAldDIZfrEjaexqAOLgVlwF4v9WSMddXOfnY+PVllgXgjWK?=
 =?us-ascii?Q?+ENBFbY4ZXAJrD3S2wUbr1wXh6nFHjKpw7l+ZydT1RDO7ac6ZcAht0ILJ+d3?=
 =?us-ascii?Q?aaeU6ObN7NaVx6N0qR8TlgJtJfTBFh4ubcGCzfIh98EFG07UkGmAbnCJTNtb?=
 =?us-ascii?Q?O3vNOMi1aCZWUzRB1Ukw0QbUbwx1rs+lRBPK08l+wjdoSIRj6PxiJGLMEpJV?=
 =?us-ascii?Q?zXr3TTN3vFS1UsLdcN3S1Sk6f4a1SG4iReuaQ2PPqX/qOIMxEJJBwOGu2BdL?=
 =?us-ascii?Q?0lCHsFTemen7NzzHN26JqkgSQFP4jjfQRTpMO44Kn44jLRl1+Spd7pb1L4NT?=
 =?us-ascii?Q?VKSj0+Ui77c2DUfaxiCu9ZNysz+ypg3t0OncY/4XDvD43TYwsUNdufM5L5/A?=
 =?us-ascii?Q?/1u+WfVCKMqGfDbPzNYmZ/1Pqo4DK7R645ybALNgk0CoDhHYuyYZKGunhimA?=
 =?us-ascii?Q?qbX+f8wjgagLGLGtwxorFMdE8OJCl91pEmZMPt4X5mZNQNmNWb9kxrqbVrv7?=
 =?us-ascii?Q?uOCFdomPbVy6QkHq/T6iF1pdZuLmNdMdThU1k+H1H64v5w02azzbhCWqykcT?=
 =?us-ascii?Q?9BJySPK4i1M7HHSaIYIDKlKDTsvGjLaHFvWjTEkl6E9V0/ynrORHDJmRB6rB?=
 =?us-ascii?Q?QqhPOqTTgAYhrxXsKtPwZrmvpyivnLXD/9FHQPSrhDMMkuwBJfB0bvl7dbGh?=
 =?us-ascii?Q?JB9+tDoa5A1ngKDaI/T+bp/YXeSsSnTXQpY9qIF0cfEiyeCPN5co4eQMPr+q?=
 =?us-ascii?Q?iZ+LdHnBOfGO6M4Tq/uLhwJRCWTYe9c8JDqDH1cVsoaEvnxFbIOcm9xtEkGR?=
 =?us-ascii?Q?z9PhE+TLKaHCKdUJ+CzEx5AeJLylXaTEvwWNxqFB7xlisxeKPD6JRAV/QUmw?=
 =?us-ascii?Q?DP5PJ5bZCJtFuQxYSX1PUa9gK62YcSqKwUXbZrVOiaXs5KE0EofrnfynKcPZ?=
 =?us-ascii?Q?dAZkBZuiepc4KovDYtQA4XggrsMK4o+dMMdGvACxA9SUi/McydSV7RdFhPEn?=
 =?us-ascii?Q?poYNNAavGavN0qE2qlcpgIzPzsu8bM0xonmZbUb6wrtYPFQahj+sAMv2eZ/k?=
 =?us-ascii?Q?DFtBXXi1lDOQRiaieIfiU+5H2p8HbKE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3759610-14aa-4e99-798a-08da4f6d75e8
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2022 07:54:37.6108
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kJsHc0V++zSj59mswj9CVQndVBjZBBJ0myLxghFZTkCKG9RZ1QkyPThyUE7ZxpT4vw196b15nTzEpJ6ll1B12i0zrUzXJ0zk6SyE7abyMgE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2308
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-16_04:2022-06-15,2022-06-16 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 bulkscore=0 spamscore=0 phishscore=0 adultscore=0 suspectscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206160029
X-Proofpoint-GUID: SoGR7CDMUgWkBer-DY3QOrn-6I1541z-
X-Proofpoint-ORIG-GUID: SoGR7CDMUgWkBer-DY3QOrn-6I1541z-
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

The for loop in brcmf_of_probe() would ideally end with something like
"i <= strlen(board_type)" instead of "i < board_type[i]".  But
fortunately, the two are equivalent.

Anyway, it's simpler to use strreplace() instead.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Suggested-by: Johannes Berg <johannes@sipsolutions.net>
---
I sent something like this last year but I did something wrong and it
never made it patchwork.  This is basically a new patch.

 drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index 083ac58f466d..811bd55f0d62 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
@@ -72,7 +72,6 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
 	/* Set board-type to the first string of the machine compatible prop */
 	root = of_find_node_by_path("/");
 	if (root) {
-		int i;
 		char *board_type;
 		const char *tmp;
 
@@ -84,10 +83,7 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
 			of_node_put(root);
 			return;
 		}
-		for (i = 0; i < board_type[i]; i++) {
-			if (board_type[i] == '/')
-				board_type[i] = '-';
-		}
+		strreplace(board_type, '/', '-');
 		settings->board_type = board_type;
 
 		of_node_put(root);
-- 
2.35.1