Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp195724iog; Fri, 17 Jun 2022 01:42:49 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tjlcEWK75abK8DbAs1TY4XlTiyto/kHbFwZFDV3rykOWvqp6z/xbKJgSqFRbnpS7VBp97S X-Received: by 2002:a05:6402:3608:b0:435:4a91:9ce2 with SMTP id el8-20020a056402360800b004354a919ce2mr6868515edb.342.1655455369405; Fri, 17 Jun 2022 01:42:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655455369; cv=none; d=google.com; s=arc-20160816; b=yus7lmUY91nMZ6JzEqB3eSKPz19g2XLQsSA4KQu3WbkcJW4sKwyxfNrutr2/81Y15f B2Iv/OGH5ZyeMViJr+CO+HIJ4XD29+AblfxpIA8q/j5yadNarN4HtOeIRfC+Iz9tDjF1 9ZmDQJOQkl3fKi0zl+QdCddu0Zhoru1f/DIa/mupA1AyPv8YOrvsLy9bjj+ldkHk4AaK xg/1bESuV0qDeHZR3ImSPf3lbpwgDu/ckk5F2CauXPJKbdIGKC7uVOR+qPFersipke7N 7I8sYzEAwhekV56jIbIkxQO50lXH5VcwtpqPsCgNI58/xz2PmfbWYRz5dSfK5SGT2iXI 2row== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=0Akty9E+4cwobC/kYyekXkzh/9JPXGz5SU1JwQ8OtfU=; b=S3fTtldRRXFyvrTjfCc3ANyY3/2xWk/0+XXd6ez97HvlfvmgmKyVRucJauZEbjJrQx xLnQ3gwyyeY4HnizrmjOf7fywj7x/aGo4+REhCuK6nPDcMZAQrpNL+M9aphdgnp4z7IW c/ZuyGi8MlwiqTMJEYr5cruaVc8ngxDy6iLjFGSkeqpSiTQcKg1S1ew75sryndfN1xjQ DzFTUejN1wm+jmMeV6zcfu8I8UyiI0XZSa1ngVvDlSehlBX6nY4W5Ot0O6XnRecIpmBN /PoMFTer5ovDehtuxoXyCKu+eH2b+qzL2w4IgyraYti4azT+kyfWfIvw1OWZBvDM3pXM Sg6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=nU3KQEiw; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr8-20020a170907720800b0070da0ccb401si1701675ejc.574.2022.06.17.01.42.26; Fri, 17 Jun 2022 01:42:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=nU3KQEiw; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380672AbiFQIkU (ORCPT + 65 others); Fri, 17 Jun 2022 04:40:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381174AbiFQIkL (ORCPT ); Fri, 17 Jun 2022 04:40:11 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70C4369B5B for ; Fri, 17 Jun 2022 01:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0Akty9E+4cwobC/kYyekXkzh/9JPXGz5SU1JwQ8OtfU=; b=nU3KQEiw7kM/xNShDAc8aV1N8q i7Ait6136VZG9uLOfQsrrkYpMrmEJu3SuNho2GalR6AwRVxF2iWCsKeM7eCcvYwmFtPVp0VwuwpNh 0deOXzmvaTPElPbQr3BstPzQpQehD9aRjXfe3Ndo9c04e8q5U2kyX8TtOd/wKNu/tzpE=; Received: from p54ae95bf.dip0.t-ipconnect.de ([84.174.149.191] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1o27Vt-0004hM-WB; Fri, 17 Jun 2022 10:39:34 +0200 Message-ID: Date: Fri, 17 Jun 2022 10:39:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] mt76: mt7921: fix aggregation subframes setting to HE max Content-Language: en-US To: Deren Wu , Lorenzo Bianconi Cc: Sean Wang , Soul Huang , YN Chen , Leon Yen , Eric-SY Chang , KM Lin , Robin Chiu , CH Yeh , Posh Sun , Eric Liang , Stella Chang , Evelyn Tsai , Ryder Lee , Shayne Chen , linux-wireless , linux-mediatek References: <7f5145276d732cb4aebcbffd6fc4a5eb852dd3be.1655393246.git.deren.wu@mediatek.com> From: Felix Fietkau In-Reply-To: <7f5145276d732cb4aebcbffd6fc4a5eb852dd3be.1655393246.git.deren.wu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 16.06.22 17:57, Deren Wu wrote: > From: Deren Wu > > mt7921/mt7922 support HE max aggregation subframes 256 for both tx/rx. > Get better throughput then before. > > Fixes: 94bb18b03d43 ("mt76: mt7921: fix max aggregation subframes setting") > Tested-by: Ming Yen Hsieh > Reviewed-by: Sean Wang > Signed-off-by: Deren Wu When I made the change that you're reverting here, I used the values from the reference SDK that I got, and the change actually seemed to improve performance in my tests. Did something change in the firmware, or is there a related chipset difference between 7921 and 7922? - Felix