Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2670774iog; Mon, 20 Jun 2022 02:02:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v0buoIlpsYPyhx5HTU5MagFYVqFbuvrRFhOXq1FkirZHFcI2UvM/PUJkOUBTCQs4FetG5e X-Received: by 2002:a05:6402:500b:b0:431:78d0:bf9d with SMTP id p11-20020a056402500b00b0043178d0bf9dmr27240941eda.184.1655715736035; Mon, 20 Jun 2022 02:02:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655715736; cv=none; d=google.com; s=arc-20160816; b=lin3ru/8OTVY/3KGuXnAKjw82uXkhk48R/ao1byolHH75S0A7oD8tu2TWieHSU7wpI mep8lVlTFDsCGSakDTZV/3veBPbDfwxG4J6lBQefhLAAc5pRumJlWda7LVSlqRNbT0X2 KBSxg3hB8ZG16a5LI8u0Lw5tZjLJUbcfwDWkbBGl95OnarxsbxAWC/DMF59cIhStaPC+ 2qo7k0tk//jDUg97d90Bi0xYT70wY8zP9brK5Hhv0OvHmREq1sL79T4aPUdvEK5/CwHa lzc8g1vP6wLJ+HcaUrGaizu44PbfSFkfa+wFtiJkqtUqA7OxyR+P6nCxBshefJuwINmE d7PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=pcMnbLxYq7msrOzOYLuluN5g/XFuJMzMbSxbMV6xiHs=; b=w9bNds9PClXN77/SptCT1PKvErl/WwUlIA+ERdWJwLp3eXdCw0RfO3ihrY9l4XNTer hjZ5MaBSC6W8ZWiau3PbTuVPtTWfblMFZsT8Kyrtbtm7j8spJ9r9Ue/deEyNAq7MN3o1 IuEYpvkDFg2i/ny89kWZKJFTwPYTrXilHf+VIGT7t5gLufehzfdDJbOjl3A+SNuvr0AG eLIFn7D3fOMv4e4KorFkT5yrs+0sFsTi2YAbymLG4xbz3ofFFVEZ8hCYH7Iz4YH2mh61 /17hEGyFMqi5uI8QX1ZoyMZYNVWuZEUGfEG4N4G9OmS0HUx/A1jB8J8LtJyPfm47I4SG NF0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PR3GANp6; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z21-20020a05640235d500b0043589f528c3si1262279edc.572.2022.06.20.02.01.38; Mon, 20 Jun 2022 02:02:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PR3GANp6; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240229AbiFTJA5 (ORCPT + 65 others); Mon, 20 Jun 2022 05:00:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240148AbiFTJAw (ORCPT ); Mon, 20 Jun 2022 05:00:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E6EFF5AF; Mon, 20 Jun 2022 02:00:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2A7F76112E; Mon, 20 Jun 2022 09:00:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AE70C3411B; Mon, 20 Jun 2022 09:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655715650; bh=yzwb89a50kjFZmjIaMeAKFjLE58t4BBZb0rlVAPAnss=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PR3GANp6Ak21sG/UAxVizxxDj2i2izpRr7KA6sR0960EgFKkvixokHjg5g3fytWUO euXbDcHnhIJFj8EszeyH1UN5QwFc8voqbPPBdTGXurkeQbxMlVpVfWgpIJGuQRtGRJ zPpnlkFWHP2dDCSHxN5OmqwpKelbfwDZKfkQU7JhtaRdvOGBEfAkQgXUjPNzJcHWm8 2VFGth6KLO/eZvUIafg4IDoPRV3dBC6yonXsEKWjWjPeYGZrNSei/JW1QHAlQRBKTZ bWG9eCpK2x8/jlTDsHH4BaBZaFlZz80Yrhn1pG+vU42qRtAXweOHEY0Gh/7s9V40M3 z1AIB5PZOCitQ== From: Kalle Valo To: Ard Biesheuvel Cc: linux-efi@vger.kernel.org, keescook@chromium.org, Dmitry Torokhov , Arend van Spriel , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Gregory Greenman , linux-input@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH 0/4] efivar: remove inappropriate uses of the efivar API References: <20220617174851.1286026-1-ardb@kernel.org> Date: Mon, 20 Jun 2022 12:00:45 +0300 In-Reply-To: <20220617174851.1286026-1-ardb@kernel.org> (Ard Biesheuvel's message of "Fri, 17 Jun 2022 19:48:47 +0200") Message-ID: <87bkunpv42.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ard Biesheuvel writes: > The efivar layer is a caching non-volatile variable store abstraction > that is normally backed by EFI, but in some cases, might be backed by > Google SMI firmware interfaces instead. > > It is mainly used by efivarfs and EFI pstore, both of which actually > need the caching and abstraction properties. However, there are a few > other occurrences where efivar is not necessary, or used in an invalid > way. So let's fix this up, and remove some impediments to refactoring > and cleaning up the efivars layer in the future. > > Assuming there are no objections to these changes, I intend to queue > them up in the EFI tree fairly soon, so that ongoing work depending on > these changes can continue as well. > [...] > drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 25 ++--- > drivers/net/wireless/intel/iwlwifi/fw/uefi.c | 96 ++++++------------ Feel free to take the wireless patches via your tree: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches