Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Jun 2022 10:03:14 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     johannes.berg@intel.com
Cc:     linux-wireless@vger.kernel.org
Subject: [bug report] wifi: nl80211: support MLO in auth/assoc
Message-ID: <YrK+sjPSFRxX4XAM@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vSL6hCTc8ugIwh8HxrdBR0efYsJ0crWnSiVDnjw/3rZn2xJiKtQcNA6/gf1I?=
 =?us-ascii?Q?qkP1RghFS6Bp6A03fcCQ1EhqwvoYKV5n/TeTYgg0tzgN14n+sD4pFjSWLi7W?=
 =?us-ascii?Q?GrqgBnHVx1pEtasUBURkfhokk0FYxaNHNteg3+BfxUV1owca5SNcDpsp1ghJ?=
 =?us-ascii?Q?BEt3Mna3k4MWl142BKa1rFf7nPTEG08aQZ9E1BGWaVFa+rBW9et9vYm/qA2l?=
 =?us-ascii?Q?gmM4a3m/r72zqf47LmkJ3HlYdNUbO8XmuEsXkEgTHomAScYtYT3fBZi+0Vf8?=
 =?us-ascii?Q?JYd9xPEUYiQEgXdJa7fYJ/GlCBkJfYlrYyielYmvNKHItvGElIPKNiGeDB10?=
 =?us-ascii?Q?E7q47tHzpAuTcHjarR5ln86m6WMtSp21qYfN0ZBy801MWzwftsezf6GlHiCV?=
 =?us-ascii?Q?dVmtN/3BKSnnmi0Q4qxDNsIcNT5/ANXAKPTtfwRBmuw7IDLkVHAidS7IU++x?=
 =?us-ascii?Q?/FgdhrPVR8F9nnwVKC75/7VyHqRn4sALJaQNcg/F/yjgU320W8npNryCOgNx?=
 =?us-ascii?Q?aLqvrmfKcy5Ac3bavEoQEGfJrIP9wvdvFRgvC2dRlkvUdKSY9RwBAsIMoBtS?=
 =?us-ascii?Q?mC2YiScSeHRmdi3YW20xLrjJbVHoxI+Vw8/dQ1nKsjnHVey/pkLh2tK55aQM?=
 =?us-ascii?Q?LN5ITumfv2ae6rHxT+xnCTGiAkwsHo1pIeOo7uLoMNZgfI17GquVll8tejaV?=
 =?us-ascii?Q?VvcrubzvA3MHXEOf5aaSDZoSpRDzyGDJDaN4zcGcoSYGk2/+6gi2Q7Hh5e7R?=
 =?us-ascii?Q?i60QnbEFRA5ERb/PAgEFKA5MwBBwIipnoM/HcMFlninp6Kue1x8Qx2xiZtWg?=
 =?us-ascii?Q?WCOgV5HiVClxD6zgh4XZX4zI9Aia+Zg/eR04bhq2PuvvNFo5Vb8WnWWZ8K4u?=
 =?us-ascii?Q?+0T4lsKOIPR69vZfRy3t/0+39t22WwZhI17cTKYuzrmHrhMcG5/1DISYC0xD?=
 =?us-ascii?Q?a80mwA7ulmZvf4TqpzsOOv4wRdTSOz/V5v/jGw3P3LcrSULDvZukRUnnaBvV?=
 =?us-ascii?Q?5az6or9cb5rHKVD5GWXt7+XoMBnghQm9EATx+YOogzJaS+weOOfJMnh4m7s2?=
 =?us-ascii?Q?tmE4ZBf1MXiH0VYTLksxOgyeTxqS4QzHEKWfgBXKjj7U8g/Hrnfpj6vs7o+A?=
 =?us-ascii?Q?Ppw2ad4pzY3qaZWatHvkvgMyvj/31HrJ6uXsssDaNxY9LZPLWmlNCqcuhcfY?=
 =?us-ascii?Q?jMV91ceKjioXBttHs8KfYnyK/zph10Jted3OgJIcyEn0ng/oCJWxQLTWBYR1?=
 =?us-ascii?Q?NYD85vWxCFe5djeOsXm0QZEhdNmlGKuZG8IGLrGdlSZ/AaN4+AJ022qGY58r?=
 =?us-ascii?Q?i1/aeTeyOgxbzYYsg9DLKOzhacdsNV9qzG9LmY9amtrd/vzml6OXbJ6cEPq5?=
 =?us-ascii?Q?WhNV7hJkH+t1fDe3Y04t2yqdxNmmr4wjnuasQHlfNn9OB4gd/h6OF4kwwCOk?=
 =?us-ascii?Q?2O6KO6oUd0f3VfKzSsNQThTiinHAvD+xiIlB7XxDqoWfKNZoXwXv9W3IdUbU?=
 =?us-ascii?Q?LmdXaJH4QqSrNYjHrmeQtjT+XwEGv0HU0arQFxSi0IYLuqyjKdvz2sHkjvT9?=
 =?us-ascii?Q?/GiFX8VH5EgrlK0h80pUVZpwW2IKQj7S5416UMDV2wDzXKsa92PJWlMesafG?=
 =?us-ascii?Q?UqZzLoXcibT/L7RCIcKrazW1O2hKdRzsSnb3hEjL++Tf7f2CZ16GvXBMIKpo?=
 =?us-ascii?Q?Q1IQm1aQ3sJ+oh0N6dOmPsc0/Cxv/la3wiLUgXmifgkJIjmshfx72i3z/jkp?=
 =?us-ascii?Q?MjxIXz2P/RdEeBr2I1Nu6xMAobluYVg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82bd95bd-3259-44e6-c05f-08da541d4d01
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2022 07:03:25.0654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0TAZ4qxr1DAMpmT4JX+4cmXbSetpRvOMIrvjmzuNgHfXvX6NiWBkVDdQdS5GuApUzMLkUXQwO82ZACvhG+XlHvKTOTjIT0w9UddgjR1tZK4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6053
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-21_11:2022-06-21,2022-06-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=888
 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206220034
X-Proofpoint-GUID: 9HY2lD4dADpzaZLdJe6P1sM-kshcANGn
X-Proofpoint-ORIG-GUID: 9HY2lD4dADpzaZLdJe6P1sM-kshcANGn
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hello Johannes Berg,

This is a semi-automatic email about new static checker warnings.

The patch d648c23024bd: "wifi: nl80211: support MLO in auth/assoc"
from May 31, 2022, leads to the following Smatch complaint:

    net/wireless/mlme.c:328 cfg80211_mlme_assoc()
    warn: variable dereferenced before check 'req->bss' (see line 324)

net/wireless/mlme.c
   323	
   324		err = rdev_assoc(rdev, dev, req);
                                            ^^^
req->bss dereferenced inside the function call

   325		if (!err) {
   326			int link_id;
   327	
   328			if (req->bss) {
                            ^^^^^^^^
Check for NULL is too late

   329				cfg80211_ref_bss(&rdev->wiphy, req->bss);
   330				cfg80211_hold_bss(bss_from_pub(req->bss));

regards,
dan carpenter