Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 19:32:20 +0100
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH v2] brcmfmac: Remove #ifdef guards for PM related
 functions
To:     Jeff Johnson <quic_jjohnson@quicinc.com>
Cc:     Arend Van Spriel <aspriel@gmail.com>,
        Franky Lin <franky.lin@broadcom.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Message-Id: <WHVZDR.GB0H9SQC9PDP@crapouillou.net>
In-Reply-To: <3013994a-487c-56eb-42d6-b8cdf7615405@quicinc.com>
References: <20220623124221.18238-1-paul@crapouillou.net>
        <9f623bb6-8957-0a9a-3eb7-9a209965ea6e@gmail.com>
        <3013994a-487c-56eb-42d6-b8cdf7615405@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

Le ven., juin 24 2022 at 09:31:22 -0700, Jeff Johnson=20
<quic_jjohnson@quicinc.com> a =E9crit :
> On 6/24/2022 2:24 AM, Arend Van Spriel wrote:
>> On 6/23/2022 2:42 PM, Paul Cercueil wrote:
>=20
> [snip]
>=20
>>> -    if (sdiodev->freezer) {
>>> +    if (IS_ENABLED(CONFIG_PM_SLEEP) && sdiodev->freezer) {
>>=20
>> This change is not necessary. sdiodev->freezer will be NULL when=20
>> =7FCONFIG_PM_SLEEP is not enabled.
>=20
> but won't the compiler be able to completely optimize the code away=20
> if the change is present?

That's correct. But do we want to complexify a bit the code for the=20
sake of saving a few bytes? I leave that as an open question to the=20
maintainer, I'm really fine with both options.

Cheers,
-Paul