Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0251f2c9-0f66-7dc9-7fb6-cc41a8dfd918@quicinc.com>
Date:   Fri, 24 Jun 2022 11:59:25 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v2] brcmfmac: Remove #ifdef guards for PM related
 functions
Content-Language: en-US
To:     Paul Cercueil <paul@crapouillou.net>
CC:     Arend Van Spriel <aspriel@gmail.com>,
        Franky Lin <franky.lin@broadcom.com>,
        <linux-wireless@vger.kernel.org>,
        <brcm80211-dev-list.pdl@broadcom.com>,
        <SHA-cyfmac-dev-list@infineon.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220623124221.18238-1-paul@crapouillou.net>
 <9f623bb6-8957-0a9a-3eb7-9a209965ea6e@gmail.com>
 <3013994a-487c-56eb-42d6-b8cdf7615405@quicinc.com>
 <WHVZDR.GB0H9SQC9PDP@crapouillou.net>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <WHVZDR.GB0H9SQC9PDP@crapouillou.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/24/2022 11:32 AM, Paul Cercueil wrote:
> Hi,
> 
> Le ven., juin 24 2022 at 09:31:22 -0700, Jeff Johnson 
> <quic_jjohnson@quicinc.com> a écrit :
>> On 6/24/2022 2:24 AM, Arend Van Spriel wrote:
>>> On 6/23/2022 2:42 PM, Paul Cercueil wrote:
>>
>> [snip]
>>
>>>> -    if (sdiodev->freezer) {
>>>> +    if (IS_ENABLED(CONFIG_PM_SLEEP) && sdiodev->freezer) {
>>>
>>> This change is not necessary. sdiodev->freezer will be NULL when 
>>> CONFIG_PM_SLEEP is not enabled.
>>
>> but won't the compiler be able to completely optimize the code away if 
>> the change is present?
> 
> That's correct. But do we want to complexify a bit the code for the sake 
> of saving a few bytes? I leave that as an open question to the 
> maintainer, I'm really fine with both options.

I'm fine either way as well. I'd have stronger opinions if ath drivers 
were involved ;)