Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <458bd8dd-29c2-8029-20f5-f746db57740a@newmedia-net.de>
Date:   Sun, 26 Jun 2022 13:03:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0
Subject: Re: [PATCH] net: wireless/broadcom: fix possible condition with no
 effect
To:     Praghadeesh T K S <praghadeeshthevendria@gmail.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     praghadeeshtks@zohomail.in, skhan@linuxfoundation.org
References: <20220625192902.30050-1-praghadeeshthevendria@gmail.com>
From:   Sebastian Gottschall <s.gottschall@newmedia-net.de>
In-Reply-To: <20220625192902.30050-1-praghadeeshthevendria@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Am 25.06.2022 um 21:29 schrieb Praghadeesh T K S:
> Fix a coccinelle warning by removing condition with no possible effect
>
> Signed-off-by: Praghadeesh T K S <praghadeeshthevendria@gmail.com>
> ---
>   drivers/net/wireless/broadcom/b43/xmit.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/b43/xmit.c b/drivers/net/wireless/broadcom/b43/xmit.c
> index 7651b1b..667a74b 100644
> --- a/drivers/net/wireless/broadcom/b43/xmit.c
> +++ b/drivers/net/wireless/broadcom/b43/xmit.c
> @@ -169,12 +169,7 @@ static u16 b43_generate_tx_phy_ctl1(struct b43_wldev *dev, u8 bitrate)
>   	const struct b43_phy *phy = &dev->phy;
>   	const struct b43_tx_legacy_rate_phy_ctl_entry *e;
>   	u16 control = 0;
> -	u16 bw;
> -
> -	if (phy->type == B43_PHYTYPE_LP)
> -		bw = B43_TXH_PHY1_BW_20;
> -	else /* FIXME */
> -		bw = B43_TXH_PHY1_BW_20;
> +	u16 bw = B43_TXH_PHY1_BW_20;
Can you check if this is a possible register typo?
>   
>   	if (0) { /* FIXME: MIMO */
>   	} else if (b43_is_cck_rate(bitrate) && phy->type != B43_PHYTYPE_LP) {