Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3047701iog; Mon, 27 Jun 2022 08:06:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vTL0xkVyXTmzgt/te+1iwz1FLZ9LgZNE0yutqRG3yRNfusDjbZxKX2yX5UCUC+Nvi19sFs X-Received: by 2002:a17:902:9885:b0:16b:8008:607a with SMTP id s5-20020a170902988500b0016b8008607amr4682656plp.159.1656342415562; Mon, 27 Jun 2022 08:06:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656342415; cv=none; d=google.com; s=arc-20160816; b=vGWwCPCqrDv32s3b7IX5RXC+9JfQMFlj/ffU74m+CROApKRqHX/UJmufEXHVITw+VY VjrdtLSGBFmOhVkH0524w7twE8ZL2vzNDln7147f1kJtlnwJmcgbs0pb7HQV9R3xQJSZ SXwmMBVx3L30KPxSwG2GkUmZBgyOkdmImUtcVjMwPC20ZhQOjz1E4gt2JPGVXA/1XXgD G76cJ9ZBDWZg/qr3v7sOdOfuFU3gCj4qHktEdau7mTS9dijqfDO+32dWTdwz6bsZwFRm SlPbqooRW9ddHalPhuTJmdwckIV7ub4apPrjj5mHdF3R2Aa3xjIlUm3eT9/9Dk0vFXCe 3XXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :from; bh=cHKQCUBBiM4gNJRCZXFg3yqIjINruZHTUeyr8uHXBXk=; b=X9L6NgLt9YZyOKe8BdjivPVk9uoqEvPXG66cT5LHnVZ3XZHsDDhamqB7pKof6jiQKs FeLNDpehm7ngH2oBN4E14rcUuE0YZ6G6HgTx3xV/Ym79H84BjpakXIDReNDnICvmM0Zh 77JsAh8MDHUZf8m80hmvdZ+KaWyKjiIIxOq8MD5XVejHpoUPZNAyu/FTN3fhopEZy+bF UoXffGVq9supRBMRLzoMruqb7GOlRosrP5UGzgj0/ZsSJpkWvNcP2dCYj7U+dFOUw8u4 MqcuKoqdmmGTs5e9gWdLu9PE/4RMCV1xJWsjfH4yo7LqA/H9svGyHCy2k3ibUXkmRt0P iKpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=jNoTMT94; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g70-20020a636b49000000b00410702fefc2si2248649pgc.390.2022.06.27.08.06.44; Mon, 27 Jun 2022 08:06:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=jNoTMT94; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237653AbiF0PC4 (ORCPT + 64 others); Mon, 27 Jun 2022 11:02:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237714AbiF0PCn (ORCPT ); Mon, 27 Jun 2022 11:02:43 -0400 Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B81D1834D for ; Mon, 27 Jun 2022 08:02:42 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1656342161; bh=cHKQCUBBiM4gNJRCZXFg3yqIjINruZHTUeyr8uHXBXk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jNoTMT94bF0H52oIEt5zGebTYV+vZh7eS8rCDmwdSCwkNF8HEca6UHeu7sUXOGFkO MeVqessLtbWblO4eJNmOEE5gaT9kmasC5y4Ai2TBrccmniTeNpRG/pMhaIPfqPVxJw xjiPHeMhKEFsBvUKraV1NdCpnwQmu3cvg0DesFcAGX2E37RR13ZMMdy1R06c5LhviZ xge625dEaYScEycyikE3xLpYriUwzof+4bAVLTHTWLESvQV1M5BUtGijAD7LUyF0/L UbeYmdvsptzT/1UyuTAOO9BrF4TDVozDvI6y14uPgeEu+79cAtQ7hFHvKep+tzS+/w /lqJRbc/VfIfg== To: Felix Fietkau , linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net Subject: Re: [PATCH 3/7] mac80211: consider aql_tx_pending when checking airtime deficit In-Reply-To: <20220625212411.36675-3-nbd@nbd.name> References: <20220625212411.36675-1-nbd@nbd.name> <20220625212411.36675-3-nbd@nbd.name> Date: Mon, 27 Jun 2022 17:02:40 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87ilomb14f.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > When queueing packets for a station, deficit only gets added once the pac= kets > have been transmitted, which could be much later. During that time, a lot= of > temporary unfairness could happen, which could lead to bursty behavior. > Fix this by subtracting the aql_tx_pending when checking the deficit in tx > scheduling. > > Signed-off-by: Felix Fietkau Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen