Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3047706iog; Mon, 27 Jun 2022 08:06:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uRA0slLGoXzN7amTr57jI/CL1f8SIgoGHwEwG+IZnXP4utIFhRWwZSkZexpGfoqIdYougy X-Received: by 2002:a17:902:ecd2:b0:16a:4028:8a92 with SMTP id a18-20020a170902ecd200b0016a40288a92mr15347250plh.97.1656342415716; Mon, 27 Jun 2022 08:06:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656342415; cv=none; d=google.com; s=arc-20160816; b=kqIp/412knHOLAKxgvixqiDwpNcbAG0eppOoe+a8J1BhCqI4EuyS2EpQX1TAsB2aBM QOU2vTsH60FxJO6A2Q2DQ5s4INSsrjcxRXBzsVHh3vNv+ZgimGg/WrcHeQDdxg3Bcp4v plhcgt47qWa7SeogcwTSQWfTTgwDxDmn31uDumLUZ/t+MbDKnd3/JWPLJzAewp9wFms4 9FydYo9ib9Z9ld390NNNL575IZgRbHi8oPsLtGaMcNMcnnQJc/hMZc/b4abTogxLSYq1 A2rEcWY01kBodytxuYoxmWntqjm4OG2pbkYZwmrb7scLp0B4lHQouhYXxrGTqUDUYYOc xvNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :from; bh=Cr9Us26F4vrb+6iqpa0pb3K3Jet58ul7jA1Lh/TH6I8=; b=Fb7h/6HFDzkP8FZj7fXVSaRa21EcIWzTosmhPoPBW48Al46WWcyS7rW9gI8gE2OhW9 DND0I7jTcJL7cGxiMWKyOd1BME5NB6Blx4uxbUtQy629ZGOU5WOQAemL+CfeBPsOI4Uw 8FzqX3T3awG0aEC98HUrNGl4v6rKFqvfQsOOhsGta5V6UCn6YvkZAPjky2TdyO/ja7h+ T99HbpJCGrYo/AAYFV/ET9nImQhwW7MZ4Ji5ye2r8F4gqma15RKMD6kKwb+p7bXZBWnq Yn62uBiY/TsTNiO7q/8XqcM3KuYj3AAsHfv62Am+n7w2zJf7TnSRpjmoeZHQphX7/yIP k2AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=on5eNecv; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n22-20020a056a0007d600b00525a80c57afsi5395219pfu.219.2022.06.27.08.06.42; Mon, 27 Jun 2022 08:06:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=on5eNecv; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237419AbiF0PCS (ORCPT + 64 others); Mon, 27 Jun 2022 11:02:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231131AbiF0PCQ (ORCPT ); Mon, 27 Jun 2022 11:02:16 -0400 Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 059DF1834D for ; Mon, 27 Jun 2022 08:02:14 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1656342133; bh=q0zFaa23yf3ciG+/3V/M99AzR9YG7OjEQu7K6ssGsYY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=on5eNecv200Q/L1CNm4uR/1UxrpTDpy+cnmzoZXT8CcZP13daGPq/2cH+W+3acDRh 39kfSXgsgurMLf1rDMX5D722hF9TJZxe3ROOGCSVCQj7Ya5Cj1pyLx1Mu+fqGO/flh Zybpl6e+6MxACiSjdal1K2vkaZid9SQsIRHu2c5Hy+ca3DVk92TrgUDhVbipCOIc9j itxbuAQWTD91nVgqxUbycsS8tj/Y4QFysqvSn1P5B3BdZyGX40cYO4hMjWxeuneiMR bloYHX65qyE6sY7CbbnlqGm9NbpkoGYvYSONLpMPJsehmRQdobjff+PSuHyBCXelVw 9OY7H9mHCSb6A== To: Felix Fietkau , linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net Subject: Re: [PATCH 1/7] mac80211: switch airtime fairness back to deficit round-robin scheduling In-Reply-To: <20220625212411.36675-1-nbd@nbd.name> References: <20220625212411.36675-1-nbd@nbd.name> Date: Mon, 27 Jun 2022 17:02:12 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87o7yeb157.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > This reverts commits 6a789ba679d652587532cec2a0e0274fda172f3b and > 2433647bc8d983a543e7d31b41ca2de1c7e2c198. > > The virtual time scheduler code has a number of issues: > - queues slowed down by hardware/firmware powersave handling were not pro= perly > handled. > - on ath10k in push-pull mode, tx queues that the driver tries to pull fr= om > were starved, causing excessive latency > - delay between tx enqueue and reported airtime use were causing excessiv= ely > bursty tx behavior > > The bursty behavior may also be present on the round-robin scheduler, but= there > it is much easier to fix without introducing additional regressions > > Signed-off-by: Felix Fietkau Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen